This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 83389

Summary:	Welcome module uses expensive SystemOption
Product:	ide	Reporter:	Petr Nejedly <pnejedly>
Component:	Welcome	Assignee:	Stanislav Aubrecht <saubrecht>
Status:	CLOSED FIXED
Severity:	blocker	CC:	issues
Priority:	P2	Keywords:	PERFORMANCE
Version:	5.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Bug Depends on:
Bug Blocks:	83490
Attachments:	patch for release55 branch

Description Petr Nejedly 2006-08-24 14:42:14 UTC

Welcome module uses expensive SystemOption, relatively speaking. In needs to
persist just two booleans, one of them visualized by it's own UI, with no need
for generic options acces nor upgrades. Yet it uses SystemOption which consumes
tens of milliseconds every startup. I propose to replace SystemOption with two
simple boolean attributes attached to the preexisting file/folder on the
module's layer.

Comment 1 Stanislav Aubrecht 2006-09-11 16:38:18 UTC

fixed in trunk

Checking in resources/layer.xml;
/cvs/ide/welcome/src/org/netbeans/modules/welcome/resources/layer.xml,v  <-- 
layer.xml
new revision: 1.7; previous revision: 1.6
done
Removing resources/WelcomeOptions.settings;
/cvs/ide/welcome/src/org/netbeans/modules/welcome/resources/WelcomeOptions.settings,v
 <--  WelcomeOptions.settings
new revision: delete; previous revision: 1.1
done
Checking in WelcomeOptions.java;
/cvs/ide/welcome/src/org/netbeans/modules/welcome/WelcomeOptions.java,v  <-- 
WelcomeOptions.java
new revision: 1.5; previous revision: 1.4
done

Comment 2 Stanislav Aubrecht 2006-09-11 16:46:35 UTC

Created attachment 33771 [details]
patch for release55 branch

Comment 3 Stanislav Aubrecht 2006-09-12 14:00:19 UTC

fixed in release55 (there's no "release55_dev" branch...)

Removing resources/WelcomeOptions.settings;
/cvs/ide/welcome/src/org/netbeans/modules/welcome/resources/Attic/WelcomeOptions.settings,v
 <--  WelcomeOptions.settings
new revision: delete; previous revision: 1.1.2.1
done
Checking in resources/layer.xml;
/cvs/ide/welcome/src/org/netbeans/modules/welcome/resources/layer.xml,v  <-- 
layer.xml
new revision: 1.1.2.10; previous revision: 1.1.2.9
done
Checking in WelcomeOptions.java;
/cvs/ide/welcome/src/org/netbeans/modules/welcome/WelcomeOptions.java,v  <-- 
WelcomeOptions.java
new revision: 1.1.2.4; previous revision: 1.1.2.3
done

Comment 4 Petr Chytil 2007-01-03 10:35:21 UTC

closed.

Comment 5 Jesse Glick 2007-06-15 02:03:22 UTC

Now updated to NbPreferences:

Checking in src/org/netbeans/modules/welcome/WelcomeOptions.java;
/shared/data/ccvs/repository/ide/welcome/src/org/netbeans/modules/welcome/WelcomeOptions.java,v  <--  WelcomeOptions.java
new revision: 1.6; previous revision: 1.5
done
Checking in nbproject/project.xml;
/shared/data/ccvs/repository/ide/welcome/nbproject/project.xml,v  <--  project.xml
new revision: 1.12; previous revision: 1.11
done