This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | I18N - some possible hard coded font or window sizes | ||
---|---|---|---|
Product: | xml | Reporter: | Ken Frank <kfrank> |
Component: | WSDL Tools | Assignee: | Nathan Fiedler <nlfiedler> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | pjiricka |
Priority: | P2 | Keywords: | I18N |
Version: | 5.x | ||
Hardware: | Sun | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
Ken Frank
2006-07-10 17:07:34 UTC
another one with non standard jdk font name hardcoded titleButton.setFont(new java.awt.Font("Tahoma", 1, 11)); schema/schemaui/src/org/netbeans/modules/xml/schema/ui/nodes/categori zed/customizer/DocumentationPanel.java ken.frank@sun.com Some of these are Enterprise Pack code, assigning to Erno for now to fix the NB part. xml/multiview part is fixed in release55 branch. http://xml.netbeans.org/source/browse/xml/multiview/src/org/netbeans/modules/ xml/multiview/ui/SectionPanel.form?r1=1.10.34.1.2.1&r2=1.10.34.1.2.2 http://xml.netbeans.org/source/browse/xml/multiview/src/org/netbeans/modules/ xml/multiview/ui/TreePanelDesignEditor.java?r1=1.4.34.1&r2=1.4.34.2 http://xml.netbeans.org/source/browse/xml/multiview/src/org/netbeans/modules/ xml/multiview/ui/SectionContainer.form?r1=1.11.58.1&r2=1.11.58.2 http://xml.netbeans.org/source/browse/xml/multiview/src/org/netbeans/modules/ xml/multiview/ui/DefaultTablePanel.form?r1=1.6&r2=1.6.60.1 http://xml.netbeans.org/source/browse/xml/multiview/src/org/netbeans/modules/ xml/multiview/ui/DefaultTablePanel.java?r1=1.7.50.2&r2=1.7.50.3 http://xml.netbeans.org/source/browse/xml/multiview/src/org/netbeans/modules/ xml/multiview/ui/SectionContainer.java?r1=1.22.54.3&r2=1.22.54.4 http://xml.netbeans.org/source/browse/xml/multiview/src/org/netbeans/modules/ xml/multiview/ui/SectionPanel.java?r1=1.38.30.1.2.4&r2=1.38.30.1.2.5 Its better to use default size for text labels. Please see org.netbeans.modules.xml.schema.ui.nodes.categorized.customizer.DocumentationPanel.java version 1.1.2.4 (diff 1.1.2.3) Its better to use default size for text labels. Please see org.netbeans.modules.xml.schema.ui.nodes.categorized.customizer.DocumentationPanel.java version 1.1.2.6 (diff 1.1.2.5) removed line titleButton.setFont(new java.awt.Font("Tahoma", 1, 11)); Hi Stepan, can you please look at the remaining occurences under xml (the ones that are part of NetBeans standard distro)? Thanks. Ken, I will remove all occurrences of the setPreferredSize call but I do not know what is wrong about the setMinimumSize call. I think it is perfectly ok to set the minimum size to some fixed value. Can you please clarify why do you want to remove the setMinimumSize call? Thanks Checking in src/org/netbeans/modules/xml/catalog/impl/XCatalogCustomizer.form; /cvs/xml/catalog/src/org/netbeans/modules/xml/catalog/impl/XCatalogCustomizer.form,v <-- XCatalogCustomizer.form new revision: 1.7.80.1; previous revision: 1.7 done Checking in src/org/netbeans/modules/xml/catalog/impl/XCatalogCustomizer.java; /cvs/xml/catalog/src/org/netbeans/modules/xml/catalog/impl/XCatalogCustomizer.java,v <-- XCatalogCustomizer.java new revision: 1.8.80.2; previous revision: 1.8.80.1 done Usage of the setPreferredSize method in the org.netbeans.modules.xml.catalog.CatalogMounterPanel is intentional and "correct" (although it is a hack), it should work OK even with larger fonts. Reassigning to ent. pack guys. for wsdltools, setPreferredSize is used in WSDLColumn. Both the schema and WSDL editors use setPreferredSize() for the individual columns in the columns view. This is necessary, otherwise the columns are sized to the content, which results in each column being a different width. This goes against the desired behavior which is to mimic Finder in MacOS X, in which each column is the same width. Moreover, we already known in advance that the contents of the columns will be of various widths, and thus we display the contents truncated as appropriate. This is intentional and by design. If you like, I can make the values come from a method call, so the scanning tool will not see them as being hard coded. Marking as fixed since everything that should be fixed has been fixed. I am the QE member ,I need to verify this bug ,Could you please let me know the steps to reproduce from scratch so that I can verify the same verified. |