This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | API review to remove final from PropertiesDataLoader, and add a String constructor. | ||
---|---|---|---|
Product: | utilities | Reporter: | charlweed <charlweed> |
Component: | Properties | Assignee: | apireviews <apireviews> |
Status: | RESOLVED WONTFIX | ||
Severity: | blocker | CC: | rkubacki |
Priority: | P3 | Keywords: | API_REVIEW |
Version: | 5.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | ENHANCEMENT | Exception Reporter: |
Description
charlweed
2006-05-22 18:09:29 UTC
-1. I don't know why this module even exposes any public packages but it should not - a mistake somewhere that should be corrected when possible. No one should be subclassing PropertiesDataLoader. Anyway I think this request is unnecessary since 1. Anyone can create a wizard iterator that does whatever substitutions they desire with no changes to the module. (As I think I already mentioned on one or the other mailing list?) 2. Any useful changes such as making *.properties replace macros consistently with e.g. *.java files, insofar as they make sense, should simply be put directly in the properties module. Any comments anywhere in the nb.org source base reading "This class is final only for performance reasons, can be unfinaled if desired." should be ignored; they are ancient (predating HotSpot and any real understanding of performance on the part of NB engineers) and contradict our API policies which are to keep all classes and methods final unless there is an API justification for them not to be. Suggest this issue be closed as WONTFIX. Anyway it is to be hoped that the whole module will be rewritten soon - basically as soon as anyone has any time to work on it. The current design of the data loader is undesirable and could be greatly simplified along with an overhaul of the UI. -1 from me as well. There should be no formal API for extending PropertiesData{Loader|Object|Node}. No reply since May, so I guess this should be closed. |