This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 67860

Summary:	Limiting access to ant/freeform packages
Product:	projects	Reporter:	Jan Lahoda <jlahoda>
Component:	Ant Freeform	Assignee:	Jan Lahoda <jlahoda>
Status:	VERIFIED FIXED
Severity:	blocker	CC:	apireviews, issues
Priority:	P3	Keywords:	API, API_REVIEW_FAST
Version:	5.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Attachments:	Proposed change.

Description Jan Lahoda 2005-10-31 18:03:38 UTC

As ant/freeform's arch document says that the ant/freeform's SPI is friend SPI,
I propose to limit the access to the public packages of ant/freeform to only
friend modules. The current list of friend modules is:
org.netbeans.modules.j2ee.ejbfreeform
org.netbeans.modules.java.freeform
org.netbeans.modules.profiler.freeform
org.netbeans.modules.web.freeform

I have also changed the name of the module from
org.netbeans.modules.ant.freeform to org.netbeans.modules.ant.freeform/1.

Comment 1 Jan Lahoda 2005-10-31 18:04:19 UTC

Created attachment 26499 [details]
Proposed change.

Comment 2 Jesse Glick 2005-10-31 18:12:01 UTC

OK with me. Note that this is an incompatible change.

Comment 3 Pavel Buzek 2005-11-01 05:42:32 UTC

ok with me

Comment 4 Jan Lahoda 2005-11-07 12:58:02 UTC

I am going to implement this change today.

Comment 5 Jan Lahoda 2005-11-07 14:37:39 UTC

Implemented:
RCS file: /cvs/ant/freeform/apichanges.xml,v
done
Checking in ant/freeform/apichanges.xml;
/cvs/ant/freeform/apichanges.xml,v  <--  apichanges.xml
initial revision: 1.1
done
Checking in ant/freeform/manifest.mf;
/cvs/ant/freeform/manifest.mf,v  <--  manifest.mf
new revision: 1.10; previous revision: 1.9
done
Checking in ant/freeform/nbproject/project.properties;
/cvs/ant/freeform/nbproject/project.properties,v  <--  project.properties
new revision: 1.21; previous revision: 1.20
done
Checking in ant/freeform/nbproject/project.xml;
/cvs/ant/freeform/nbproject/project.xml,v  <--  project.xml
new revision: 1.18; previous revision: 1.17
done
Checking in java/freeform/manifest.mf;
/cvs/java/freeform/manifest.mf,v  <--  manifest.mf
new revision: 1.6; previous revision: 1.5
done
Checking in java/freeform/nbproject/project.xml;
/cvs/java/freeform/nbproject/project.xml,v  <--  project.xml
new revision: 1.11; previous revision: 1.10
done
Checking in j2ee/ejbfreeform/manifest.mf;
/cvs/j2ee/ejbfreeform/manifest.mf,v  <--  manifest.mf
new revision: 1.8; previous revision: 1.7
done
Checking in j2ee/ejbfreeform/nbproject/project.xml;
/cvs/j2ee/ejbfreeform/nbproject/project.xml,v  <--  project.xml
new revision: 1.13; previous revision: 1.12
done
Checking in web/freeform/manifest.mf;
/cvs/web/freeform/manifest.mf,v  <--  manifest.mf
new revision: 1.5; previous revision: 1.4
done
Checking in web/freeform/nbproject/project.xml;
/cvs/web/freeform/nbproject/project.xml,v  <--  project.xml
new revision: 1.10; previous revision: 1.9
done

Comment 6 Jaromir Uhrik 2006-01-16 15:43:57 UTC

Marking this issue as VERIFIED since the issue reporter == issue owner.