This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 65714

Summary:	Expensive File.normalize() in FileUtil.toFileObject()
Product:	platform	Reporter:	_ rkubacki <rkubacki>
Component:	Filesystems	Assignee:	rmatous <rmatous>
Status:	RESOLVED FIXED
Severity:	blocker	CC:	apireviews, issues, rmatous
Priority:	P2	Keywords:	API_REVIEW_FAST, PERFORMANCE
Version:	5.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Bug Depends on:
Bug Blocks:	65135
Attachments:	diff - request for API review + apichanges.xml OK - reworked

Description _ rkubacki 2005-10-03 14:45:53 UTC

File.normalize() is an expensive call and if we do it during every
FileUtil.toFileObject(). Although we declare that IAE is thrown if not
normalized file is passed as an argument we should make our best effort to avoid
these calls. Probably the check should be performed as assert.

Part of reason why this is slow is that it directly accesses I/O using calls
like File.isDirectory().

Comment 1 _ rkubacki 2005-10-13 09:31:24 UTC

Raising priority to P2. It might need API change but it is desirable to do it
for 5.0. Even the initial intent was to assure that correct args are passed
during development. That's really a job for assertion.

Comment 2 rmatous 2005-10-25 13:45:41 UTC

Created attachment 26315 [details]
diff - request for API review + apichanges.xml

Comment 3 rmatous 2005-10-25 13:50:50 UTC

FileUtil.toFileObject won't throw IllegalArgumentException anymore. More info in
attachment.

Comment 4 Jesse Glick 2005-10-25 14:41:49 UTC

1. You left the "throws IAE" in the method signature.

2. I don't think an assertion is appropriate here, for the usual reasons - never
use assertions to check args on public methods. However I might suggest

boolean asserts = false;
assert asserts = true;
if (asserts && !file.equals(normalizeFile(file))) {
    throw new IllegalArgumentException(...);
}

This would still make sure we catch errors in dev builds, but yield better
performance in release builds. (We *do* measure performance with assertions
disabled, right...?)

Comment 5 rmatous 2005-10-25 16:06:40 UTC

Created attachment 26323 [details]
OK - reworked

Comment 6 _ rkubacki 2005-10-27 08:37:13 UTC

Obviously +1 from me to integrate the patch :-)

To Jesse: yes, we replace netbeans.conf for performance testing to use the same
set of switches as you plan for release.

Comment 7 rmatous 2005-11-02 09:51:17 UTC

Will be integrated.

Comment 8 rmatous 2005-11-02 10:09:07 UTC

/cvs/openide/fs/apichanges.xml,v  <--  apichanges.xml
new revision: 1.5; previous revision: 1.4

/cvs/openide/fs/src/org/openide/filesystems/FileUtil.java,v  <--  FileUtil.java
new revision: 1.11; previous revision: 1.10

Comment 9 Quality Engineering 2008-12-23 14:34:18 UTC

This issue had *1 votes* before move to platform component