This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 62617

Summary:	Add support for help IDs into the view model
Product:	debugger	Reporter:	Martin Entlicher <mentlicher>
Component:	Code	Assignee:	Martin Entlicher <mentlicher>
Status:	CLOSED FIXED
Severity:	blocker	Keywords:	API, API_REVIEW_FAST
Priority:	P2
Version:	5.x
Hardware:	All
OS:	All
Issue Type:	ENHANCEMENT	Exception Reporter:
Bug Depends on:
Bug Blocks:	61693
Attachments:	set/getHelpId() methods added. Slightly modified change with test added.

Description Martin Entlicher 2005-08-18 18:00:12 UTC

In order to have a help ID defined for the propery sheet, which is created from
the debugger view model, we need a possibility to set the help ID on the
CompountModel.

Comment 1 Martin Entlicher 2005-08-18 18:14:51 UTC

Created attachment 24059 [details]
set/getHelpId() methods added.

Comment 2 Martin Entlicher 2005-08-18 18:15:42 UTC

Please review this simple API addition, that is necessary for issue #61693.
Thanks.

Comment 3 Martin Entlicher 2005-08-19 16:42:55 UTC

Created attachment 24085 [details]
Slightly modified change with test added.

Comment 4 Martin Entlicher 2005-08-19 16:44:50 UTC

The API change was slightly modified according to private comments from Yarda.
Rather then public setter, we added a new factory method with the
propertiesHelpID argument. Also the test is included.

Comment 5 Jaroslav Tulach 2005-08-19 17:16:02 UTC

Ok, from my point of view.

Comment 6 Martin Entlicher 2005-08-25 11:00:38 UTC

Thanks for the review, I'm going to commit this later today...

Comment 7 Martin Entlicher 2005-08-25 13:51:13 UTC

Fixed in trunk:

/cvs/debuggercore/viewmodel/apichanges.xml,v  <--  apichanges.xml
new revision: 1.15; previous revision: 1.14

/cvs/debuggercore/viewmodel/manifest.mf,v  <--  manifest.mf
new revision: 1.13; previous revision: 1.12

/cvs/debuggercore/viewmodel/src/org/netbeans/modules/viewmodel/TreeModelNode.java,v
 <--  TreeModelNode.java
new revision: 1.39; previous revision: 1.38

/cvs/debuggercore/viewmodel/src/org/netbeans/spi/viewmodel/Models.java,v  <-- 
Models.java
new revision: 1.24; previous revision: 1.23

/cvs/debuggercore/viewmodel/test/unit/src/org/netbeans/api/viewmodel/BasicTest.java,v
 <--  BasicTest.java
new revision: 1.10; previous revision: 1.9

Comment 8 Quality Engineering 2010-04-29 09:24:34 UTC

Verified ... and Closing all issues resolved into NetBeans 6.7 and earlier.