This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Adding swing-layout library | ||
---|---|---|---|
Product: | ide | Reporter: | Tomas Pavek <tpavek> |
Component: | libs | Assignee: | Tomas Pavek <tpavek> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | Keywords: | API_REVIEW_FAST |
Priority: | P1 | ||
Version: | 5.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | TASK | Exception Reporter: | |
Attachments: | new module project and diff (zipped) |
Description
Tomas Pavek
2005-08-17 14:50:08 UTC
Created attachment 23993 [details]
new module project and diff (zipped)
kindly asking for review... Mostly looks OK. I would recommend the codenamebase "org.jdesktop.layout" for clarity. project.xml does not need <subpackages> - there is only one package! libs/external/build.xml patch is probably wrong: the JAR is in CVS directly, yes? So don't delete it. {build,cluster}.properties: please keep lists alphabetized for easy maintenance. > I would recommend the codenamebase "org.jdesktop.layout" for clarity. Ok, makes sense - though I thought "org.netbeans.libs..." is sort of convention for lib integration modules. > project.xml does not need <subpackages> - there is only one package! Yes, I'll change to <package>. > libs/external/build.xml patch is probably wrong: the JAR is in CVS directly, > yes? So don't delete it. Oh, good catch. The jar would be deleted only if scrambled. So I won't change libs/external/build.xml. > {build,cluster}.properties: please keep lists alphabetized for easy > maintenance. Ok, I'll make sure before committing. Thanks for review. Integrated to trunk. Checking in form/nbproject/project.xml; /cvs/form/nbproject/project.xml,v <-- project.xml new revision: 1.22; previous revision: 1.21 done Removing form/release/modules/ext/swing-layout.jar; /cvs/form/release/modules/ext/swing-layout.jar,v <-- swing-layout.jar new revision: delete; previous revision: 1.7 done Checking in form/src/org/netbeans/modules/form/FormEditor.java; /cvs/form/src/org/netbeans/modules/form/FormEditor.java,v <-- FormEditor.java new revision: 1.76; previous revision: 1.75 done Checking in form/src/org/netbeans/modules/form/resources/Bundle.properties; /cvs/form/src/org/netbeans/modules/form/resources/Bundle.properties,v <-- Bundle.properties new revision: 1.11; previous revision: 1.10 done Checking in form/src/org/netbeans/modules/form/resources/layer.xml; /cvs/form/src/org/netbeans/modules/form/resources/layer.xml,v <-- layer.xml new revision: 1.86; previous revision: 1.85 done Removing form/src/org/netbeans/modules/form/resources/layoutext.xml; /cvs/form/src/org/netbeans/modules/form/resources/layoutext.xml,v <-- layoutext.xml new revision: delete; previous revision: 1.2 done Checking in ide/golden/deps.txt; /cvs/ide/golden/deps.txt,v <-- deps.txt new revision: 1.172; previous revision: 1.171 done Checking in ide/golden/files-layout.txt; /cvs/ide/golden/files-layout.txt,v <-- files-layout.txt new revision: 1.92; previous revision: 1.91 done Checking in ide/golden/modules.txt; /cvs/ide/golden/modules.txt,v <-- modules.txt new revision: 1.46; previous revision: 1.45 done Checking in ide/golden/public-packages.txt; /cvs/ide/golden/public-packages.txt,v <-- public-packages.txt new revision: 1.37; previous revision: 1.36 done RCS file: /cvs/libs/external/swing-layout-0.6.1.jar,v done Checking in libs/external/swing-layout-0.6.1.jar; /cvs/libs/external/swing-layout-0.6.1.jar,v <-- swing-layout-0.6.1.jar initial revision: 1.1 done RCS file: /cvs/libs/swing-layout/.cvsignore,v done Checking in libs/swing-layout/.cvsignore; /cvs/libs/swing-layout/.cvsignore,v <-- .cvsignore initial revision: 1.1 done RCS file: /cvs/libs/swing-layout/build.xml,v done Checking in libs/swing-layout/build.xml; /cvs/libs/swing-layout/build.xml,v <-- build.xml initial revision: 1.1 done RCS file: /cvs/libs/swing-layout/manifest.mf,v done Checking in libs/swing-layout/manifest.mf; /cvs/libs/swing-layout/manifest.mf,v <-- manifest.mf initial revision: 1.1 done RCS file: /cvs/libs/swing-layout/nbproject/.cvsignore,v done Checking in libs/swing-layout/nbproject/.cvsignore; /cvs/libs/swing-layout/nbproject/.cvsignore,v <-- .cvsignore initial revision: 1.1 done RCS file: /cvs/libs/swing-layout/nbproject/project.properties,v done Checking in libs/swing-layout/nbproject/project.properties; /cvs/libs/swing-layout/nbproject/project.properties,v <-- project.properties initial revision: 1.1 done RCS file: /cvs/libs/swing-layout/nbproject/project.xml,v done Checking in libs/swing-layout/nbproject/project.xml; /cvs/libs/swing-layout/nbproject/project.xml,v <-- project.xml initial revision: 1.1 done RCS file: /cvs/libs/swing-layout/src/org/netbeans/libs/layoutext/Bundle.properties,v done Checking in libs/swing-layout/src/org/netbeans/libs/layoutext/Bundle.properties; /cvs/libs/swing-layout/src/org/netbeans/libs/layoutext/Bundle.properties,v <-- Bundle.properties initial revision: 1.1 done RCS file: /cvs/libs/swing-layout/src/org/netbeans/libs/layoutext/layer.xml,v done Checking in libs/swing-layout/src/org/netbeans/libs/layoutext/layer.xml; /cvs/libs/swing-layout/src/org/netbeans/libs/layoutext/layer.xml,v <-- layer.xml initial revision: 1.1 done RCS file: /cvs/libs/swing-layout/src/org/netbeans/libs/layoutext/swing-layout.xml,v done Checking in libs/swing-layout/src/org/netbeans/libs/layoutext/swing-layout.xml; /cvs/libs/swing-layout/src/org/netbeans/libs/layoutext/swing-layout.xml,v <-- swing-layout.xml initial revision: 1.1 done Checking in nbbuild/build.properties; /cvs/nbbuild/build.properties,v <-- build.properties new revision: 1.315; previous revision: 1.314 done Checking in nbbuild/cluster.properties; /cvs/nbbuild/cluster.properties,v <-- cluster.properties new revision: 1.121; previous revision: 1.120 done Checking in nbbuild/nbproject/project.xml; /cvs/nbbuild/nbproject/project.xml,v <-- project.xml new revision: 1.22; previous revision: 1.21 done Done. |