This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Adding Extensions to the Web Module API/SPI | ||
---|---|---|---|
Product: | javaee | Reporter: | Petr Pisl <ppisl> |
Component: | Code | Assignee: | Petr Pisl <ppisl> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | apireviews, mkleint |
Priority: | P3 | Keywords: | API_REVIEW_FAST |
Version: | 5.x | ||
Hardware: | All | ||
OS: | Linux | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
The manifest and apichanges diff
The zip file with the classes which will be added |
Description
Petr Pisl
2005-07-28 16:11:00 UTC
Created attachment 23351 [details]
The manifest and apichanges diff
Created attachment 23352 [details]
The zip file with the classes which will be added
An example is worth many words. For instance I do not know how LibraryInfo/WebExtensionProvider should implement isInWebModule(). Is this stored somewhere in project data or is it computed always. Is it expected that true will be returned even if the framework/library is used but was not insterted using the API? Operations called on StyledDocument can fail - how do you expect to handle this? As I see you are not going to support removing of extension from web module. Perpahs it is not a big problem. Only a minor comments: A few System.out.println and exception handling using e.printStackTrace(). @link org.netbeans.modules.web.struts.LibraryInfo is probably a mistake. Missing @since tags. Some typos like whish/which Hi Radim, > For instance I do not know how > LibraryInfo/WebExtensionProvider should > implement isInWebModule(). Is this > stored somewhere in project data > or is it computed always. For example Struts Extension looks for appropriate servlet in the deployment descriptor. The information is cashed in the Struts Extension, but this is implementation issue. The JSTL library looks for the standard.jar on the web module classpath. I think, that really depends on the implementation - the way how to find it and the cashing or storing as well. > Is it expected that true will be returned even > if the framework/library is used but was not > insterted using the API? Yes, for example in the freeform. In the freeform project user is not able to extend the web module through the api. But the extension can return, that is part of the project and ide can work with this. > Operations called on StyledDocument can fail - > how do you expect to handle this? You are right. Maybe the method should throws an exception. > As I see you are not going to support removing > of extension from web module. Perpahs it is not > a big problem. Yes, it's true. I didn't find an IDE, which support removing the extensions. It's no so easy. You don't know what you should remove etc. Because we don't have time to implement correctly the feature with the libraries, I'm going to commit only the framework support part. Petr, can I ask what's the current status? Thanks. So framework part was committed before feature freaze. No TCR, no TCA. |