This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 59671

Summary:	OpenIDE-Module-Requires: org.openide.modules.ModuleFormat1 is not added to modules whose manifest.mf already specifies some OpenIDE-Module-Requires
Product:	www	Reporter:	Jesse Glick <jglick>
Component:	Builds & Repositories	Assignee:	Jesse Glick <jglick>
Status:	RESOLVED FIXED
Severity:	blocker	CC:	jtulach
Priority:	P2
Version:	5.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Bug Depends on:
Bug Blocks:	201695

Description Jesse Glick 2005-06-06 21:18:37 UTC

JarWithModuleAttributes just tries to add this manifest line, but that cannot
work - if manifest.mf already defines it, this is ignored. Check e.g. xml/css.

Not sure how to solve this other than by forcing modules to move their OIDE-M-R
declarations to project.xml and have the line always be generated. Any other
ideas that would be simpler?

Comment 1 Jesse Glick 2005-07-12 20:44:39 UTC

Found a fix.

Comment 2 Jesse Glick 2005-07-13 22:58:10 UTC

Fixed w/ issue #58248:

committed   * Up-To-Date  1.91        ide/golden/deps.txt
committed   * Up-To-Date  1.6        
nbbuild/antsrc/org/netbeans/nbbuild/JarWithModuleAttributes.java

Comment 3 Jaroslav Tulach 2012-04-16 13:36:25 UTC

I am surprised, we want to forcibly increment the ModuleFormat. I would expect that, if the module defines its own, it should take precedence. I am not sure why upgrading is useful at all?

Comment 4 Jesse Glick 2012-04-16 22:54:47 UTC

(In reply to comment #3)
> I would expect that, if the module defines its own, it should take precedence.

Is that not already true? Then file a bug for it.