This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Review of MoveClassRefactoring API change | ||
|---|---|---|---|
| Product: | editor | Reporter: | Jan Becicka <jbecicka> |
| Component: | Refactoring | Assignee: | Jan Becicka <jbecicka> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | Keywords: | API, API_REVIEW_FAST |
| Priority: | P3 | ||
| Version: | 5.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | TASK | Exception Reporter: | |
| Attachments: |
Javadoc
Proposed change |
||
Created attachment 21969 [details]
Javadoc
Created attachment 21970 [details]
Proposed change
Can you replace DataObject with FileObject in API? If so, please do that. Do not forget to increase spec version (maybe also impl one as this is incompatible change), write apichanges, use @since tag. Also this module provides friend API, so please use <friend-package> instead of <public-package> in project.xml in the same way as for example freeform/java does. > Can you replace DataObject with FileObject in API? If so, please do that.
Sorry, I cannot. Anyway this is not related to this change. MoveClassRefactoing
used DataObjects before this change.
Rest of issues implemented.
Fixed. |
I'd like to ask you for review of API change in MoveClassRefactoring API. This API change is needed for rewrite of refactoring D'n'D support. See NbFeature1077 for details. methods removed: =============== public void setTarget(FileObject target) public boolean isInvokedAfterFileMove() public MoveClassRefactoring(Collection resources, boolean invokedAfterDOMove) method added: ============ public MoveClassRefactoring(Collection dataObjects, FileObject target) public Collection getSelectedDataObjects() { getTargetPackageName(Resource r) getTargetPackageName(FileObject fo) setTargetClassPathRoot(FileObject target) method signatures changed: ========================= MoveClassRefactoring(FileObject sourceFolder) -> MoveClassRefactoring(FileObject sourceFolder, boolean isPackage) public void setNewPackageName(String name) -> setTargetPackageName(String name) getTargetClassPathRoot(Resource r) -> getTargetClassPathRoot()