This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Inplace rename breaks the code | ||
|---|---|---|---|
| Product: | java | Reporter: | Jiri Skrivanek <jskrivanek> |
| Component: | Unsupported | Assignee: | issues@java <issues> |
| Status: | CLOSED FIXED | ||
| Severity: | blocker | Keywords: | REGRESSION |
| Priority: | P2 | ||
| Version: | 4.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Attachments: | Test project. | ||
Created attachment 21568 [details]
Test project.
I found there is problem with inplace rename. Preview of refactoring shows the class twice. Sometimes it throws NPE from find usages: java.lang.NullPointerException org.netbeans.modules.refactoring.ui.RefactoringPanel.createNode(RefactoringPanel.java:391) org.netbeans.modules.refactoring.ui.RefactoringPanel.createNode(RefactoringPanel.java:489) org.netbeans.modules.refactoring.ui.RefactoringPanel.access$1200(RefactoringPanel.java:69) org.netbeans.modules.refactoring.ui.RefactoringPanel$8.run(RefactoringPanel.java:732) org.openide.util.Task.run(Task.java:189) org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:330) org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:721) The renamed file also has to be opened in editor. Lowering priority to P2. This issue is caused by fix of issue #56152 Issue #56152 rolled back. Checking in src/org/netbeans/modules/java/JavaDataObject.java; /cvs/java/src/org/netbeans/modules/java/JavaDataObject.java,v <-- JavaDataObject.java new revision: 1.204; previous revision: 1.203 done Checking in javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/ResourceImpl.java; /cvs/java/javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/ResourceImpl.java,v <-- ResourceImpl.java new revision: 1.80; previous revision: 1.79 done The diff seems to be ok. Works well for me in dev build 20050414-1056. Fixed in release41 branch. Checking in src/org/netbeans/modules/java/JavaDataObject.java; /cvs/java/src/org/netbeans/modules/java/JavaDataObject.java,v <-- JavaDataObject.java new revision: 1.203.2.1; previous revision: 1.203 done Checking in javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/ResourceImpl.java; /cvs/java/javacore/src/org/netbeans/modules/javacore/jmiimpl/javamodel/ResourceImpl.java,v <-- ResourceImpl.java new revision: 1.78.2.2; previous revision: 1.78.2.1 done Verified in NB4.1 20050414-2343. |
If you rename class and do refactoring then resulting code is broken. To reproduce: - open attached project in IDE - rename class MyTest in Test Packages to MyOverallTest - confirm refactoring dialog and do refactoring - the result is as follows: suite.addTest(new MyOverallTestallTest("test1")); suite.addTeMyOverallTest MyOverallTest("test2")); suitMyOverallTestest(new MyOverallTest("test3")); MyOverallTestte.addTest(new MyOverallTest("test4")); while originally was: suite.addTest(new MyTest("test1")); suite.addTest(new MyTest("test2")); suite.addTest(new MyTest("test3")); suite.addTest(new MyTest("test4")); Build 20050412-0810, JDK1.5.0_02, WindowsXP.