This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 55442

Summary:	Remove dependency of the tasklist/api and tasklist/docscan modules on java modules
Product:	platform	Reporter:	Jan Lahoda <jlahoda>
Component:	Action Items	Assignee:	apireviews <apireviews>
Status:	CLOSED FIXED
Severity:	blocker	CC:	tasklist-issues
Priority:	P2	Keywords:	API_REVIEW_FAST
Version:	4.x
Hardware:	All
OS:	All
Issue Type:	TASK	Exception Reporter:
Attachments:	Diff against tasklist module. Diff against nbbuild module. Diff against ide module.

Description Jan Lahoda 2005-02-23 22:54:39 UTC

Currently, the tasklist/api module depends on
org.netbeans.modules.java module. Similarily, the
tasklist/docscan module depends on the
org.netbeans.api.java module.

I do not see any reason why these modules should
depend on java modules: they currently do not use
any functionality from them. I therefore propose
to remove these dependecies between tasklist/api
and tasklist/docscan modules and java modules.

I am attaching proposed diffs against tasklist,
nbbuild and ide CVS modules (tasklist.diff,
nbbuild.diff and ide.diff, respectivelly).

Tasklist maintainers, do you agree?

Comment 1 Jan Lahoda 2005-02-23 22:55:17 UTC

Created attachment 20494 [details]
Diff against tasklist module.

Comment 2 Jan Lahoda 2005-02-23 22:55:51 UTC

Created attachment 20495 [details]
Diff against nbbuild module.

Comment 3 Jan Lahoda 2005-02-23 22:56:29 UTC

Created attachment 20496 [details]
Diff against ide module.

Comment 4 Jan Lahoda 2005-02-23 23:01:33 UTC

Only a clarification: the tasklist/api uses functionality of the java
module through the Java reflection mechanism (see issue #52707). But,
it does not use directly any Java module API and should work correctly
without java modules.

Comment 5 Jaroslav Tulach 2005-02-24 07:36:40 UTC

Seems nicer than before to me.

Comment 6 Ondrej Rypacek 2005-02-24 11:39:12 UTC

I have no objections,the dependency really seems superfluous.

Checked in:
  1.114
tasklist/docscan/src/org/netbeans/modules/tasklist/docscan/SourceTasksView.java
  1.53 tasklist/docscan/manifest.mf
  1.25 tasklist/docscan/build.xml
  1.5 tasklist/api/nbproject/project.xml
  1.643 nbbuild/build.xml
  1.39 ide/golden/deps.txt

Comment 7 Jan Lahoda 2005-03-07 15:21:41 UTC

Verified.