This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 44711

Summary:	[GTK] Superfluous shadows around components
Product:	platform	Reporter:	_ rkubacki <rkubacki>
Component:	Window System	Assignee:	_ tboudreau <tboudreau>
Status:	CLOSED FIXED
Severity:	blocker	CC:	dsimonek, issues
Priority:	P2	Keywords:	GTK, PERFORMANCE
Version:	4.x
Hardware:	PC
OS:	Linux
Issue Type:	DEFECT	Exception Reporter:

Description _ rkubacki 2004-06-10 16:28:14 UTC

dev build from Jun 10, Linux fedora core 2,
JDK1.5.0b54

When the IDE runs with GTK L&F we add shadows
implemented in AdaptiveMatteBorder to the most of
components - view tabs, editor tabs, toolbars.
This is probably objectionable as I do not see
anything similar neither in native applications
(using GNOME2.6.0 with bluecurve/blueprint from
JDS/crux) nor in SwingSet2 demo. 

Thanks to Scott Violet we also know that painting
of these shadows is expensive as they use
translucent colors. It means there is on emore
reason to avoid them.

Besides this the current implementation is wrong
IMO. In the paintBorder(Component c, Graphics g,
int x, int y, int w, int h) method pixels with x
coordinate greater or equal to x+w are painted and
pixels with y0 >= y+h too.

Comment 1 _ tboudreau 2004-06-26 20:13:57 UTC

I've eliminated the use of transparent colors in the shadows.  They'll
look slightly less nice if you're using a theme with a patterned
background, but even then the difference should be only barely detectable.

We can debate the aesthetic matter of whether there should be shadows
or not (as mentioned somewhere else, they're emulating e!e for what
it's worth).  


Checking in
plaf/src/org/netbeans/swing/plaf/aqua/AquaToolBarButtonUI.java;
/cvs/core/swing/plaf/src/org/netbeans/swing/plaf/aqua/AquaToolBarButtonUI.java,v
 <--  AquaToolBarButtonUI.java
new revision: 1.4; previous revision: 1.3
done
Processing log script arguments...
More commits to come...
Checking in plaf/src/org/netbeans/swing/plaf/gtk/AdaptiveMatteBorder.java;
/cvs/core/swing/plaf/src/org/netbeans/swing/plaf/gtk/AdaptiveMatteBorder.java,v
 <--  AdaptiveMatteBorder.java
new revision: 1.5; previous revision: 1.4
done
Checking in plaf/src/org/netbeans/swing/plaf/gtk/GtkToolBarButtonUI.java;
/cvs/core/swing/plaf/src/org/netbeans/swing/plaf/gtk/GtkToolBarButtonUI.java,v
<--  GtkToolBarButtonUI.java
new revision: 1.6; previous revision: 1.5
done
Processing log script arguments...
More commits to come...
Checking in
tabcontrol/src/org/netbeans/swing/tabcontrol/TabbedContainer.java;
/cvs/core/swing/tabcontrol/src/org/netbeans/swing/tabcontrol/TabbedContainer.java,v
 <--  TabbedContainer.java
new revision: 1.6; previous revision: 1.5
done
Processing log script arguments...
Mailing the commit message to cvs@core.netbeans.org (from
tboudreau@netbeans.org)

Comment 2 Marian Mirilovic 2005-07-14 17:44:24 UTC

closed