This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | ToggleBreakpointAction(s) cannot have the same shortcut | ||
|---|---|---|---|
| Product: | debugger | Reporter: | Martin Grebac <mgrebac> |
| Component: | Java | Assignee: | Jan Jancura <jjancura> |
| Status: | CLOSED FIXED | ||
| Severity: | blocker | Keywords: | REGRESSION |
| Priority: | P1 | ||
| Version: | 4.x | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Bug Depends on: | |||
| Bug Blocks: | 27194 | ||
|
Description
Martin Grebac
2004-04-07 17:44:41 UTC
As far as I understand the problem this is about API to toggle
breakpoint between debugger(core) and java module. Thanks Hanz, for
telling me about that.
The correct solution is define a key (like "toggle-breakpoint"):
1. Write one global ToggleBreakpoint action implements swng.Action,
ContextAwareAction and listens on ActionMap in its Lookup (or
Utilities.actionsGlobalContext()) and delegates to the
actionMap.getAction ("toggle-breakpoint").
2. Reuse what is already written in CallbackSystemAction. Return the
key from its protected method, to be sure override setActionPerformer
- this method is deprecated and you do want to support it.
Of course you need to register the global action in menu a shortcuts
folder and you should write a test, definitively in example 1.
Do not listen to him, Martin!!! fixed in the main trunk - ACTION_TOGGLE_BREAKPOINt has been added to DebuggerManager. Use standard - ActionProvider to implement toggle action now Checking in api/src/org/netbeans/api/debugger/DebuggerManager.java; /cvs/debuggercore/api/src/org/netbeans/api/debugger/DebuggerManager.java,v <-- DebuggerManager.java new revision: 1.10; previous revision: 1.9 done Processing log script arguments... More commits to come... Checking in src/org/netbeans/modules/debugger/ui/actions/Bundle.properties; /cvs/debuggercore/src/org/netbeans/modules/debugger/ui/actions/Bundle.properties,v <-- Bundle.properties new revision: 1.5; previous revision: 1.4 done Checking in src/org/netbeans/modules/debugger/ui/actions/ToggleBreakpointAction.java; /cvs/debuggercore/src/org/netbeans/modules/debugger/ui/actions/ToggleBreakpointAction.java,v <-- ToggleBreakpointAction.java new revision: 1.2; previous revision: 1.1 done cvs diff: ToggleBreakpointAction.java is a new entry, no comparison availableChecking in ant/antsrc/org/netbeans/modules/debugger/jpda/ant/JPDAStart.java; /cvs/debuggerjpda/ant/antsrc/org/netbeans/modules/debugger/jpda/ant/JPDAStart.java,v <-- JPDAStart.java new revision: 1.16; previous revision: 1.15 done Processing log script arguments... More commits to come... Checking in ant/src/org/netbeans/modules/debugger/projects/FixActionProvider.java; /cvs/debuggerjpda/ant/src/org/netbeans/modules/debugger/projects/FixActionProvider.java,v <-- FixActionProvider.java new revision: 1.2; previous revision: 1.1 done Processing log script arguments... More commits to come... Checking in src/org/netbeans/modules/debugger/jpda/breakpoints/JPDAClassBreakpointImpl.java; /cvs/debuggerjpda/src/org/netbeans/modules/debugger/jpda/breakpoints/JPDAClassBreakpointImpl.java,v <-- JPDAClassBreakpointImpl.java new revision: 1.4; previous revision: 1.3 done Checking in src/org/netbeans/modules/debugger/jpda/breakpoints/JPDALineBreakpointImpl.java; /cvs/debuggerjpda/src/org/netbeans/modules/debugger/jpda/breakpoints/JPDALineBreakpointImpl.java,v <-- JPDALineBreakpointImpl.java new revision: 1.9; previous revision: 1.8 done Processing log script arguments... More commits to come... RCS file: /cvs/debuggerjpda/ui/src/META-INF/debugger/org.netbeans.spi.debugger.ActionsProvider,v done Checking in ui/src/META-INF/debugger/org.netbeans.spi.debugger.ActionsProvider; /cvs/debuggerjpda/ui/src/META-INF/debugger/org.netbeans.spi.debugger.ActionsProvider,v <-- org.netbeans.spi.debugger.ActionsProvider initial revision: 1.1 done Processing log script arguments... More commits to come... Checking in ui/src/META-INF/debugger/netbeans-JPDASession/org.netbeans.spi.debugger.ActionsProvider; /cvs/debuggerjpda/ui/src/META-INF/debugger/netbeans-JPDASession/org.netbeans.spi.debugger.ActionsProvider,v <-- org.netbeans.spi.debugger.ActionsProvider new revision: 1.3; previous revision: 1.2 done Processing log script arguments... More commits to come... Checking in ui/src/org/netbeans/modules/debugger/jpda/resources/mf-layer.xml; /cvs/debuggerjpda/ui/src/org/netbeans/modules/debugger/jpda/resources/mf-layer.xml,v <-- mf-layer.xml new revision: 1.10; previous revision: 1.9 done Processing log script arguments... More commits to come... Removing ui/src/org/netbeans/modules/debugger/jpda/ui/actions/ToggleBreakpointAction.java; /cvs/debuggerjpda/ui/src/org/netbeans/modules/debugger/jpda/ui/actions/ToggleBreakpointAction.java,v <-- ToggleBreakpointAction.java new revision: delete; previous revision: 1.5 done RCS file: /cvs/debuggerjpda/ui/src/org/netbeans/modules/debugger/jpda/ui/actions/ToggleBreakpointActionProvider.java,v done Checking in ui/src/org/netbeans/modules/debugger/jpda/ui/actions/ToggleBreakpointActionProvider.java; /cvs/debuggerjpda/ui/src/org/netbeans/modules/debugger/jpda/ui/actions/ToggleBreakpointActionProvider.java,v <-- ToggleBreakpointActionProvider.java initial revision: 1.1 done Verified in build from 24.5.2004 |