This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | memory leak in search | ||
---|---|---|---|
Product: | utilities | Reporter: | bwl <bwl> |
Component: | Search | Assignee: | Antonin Nebuzelsky <anebuzelsky> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | anebuzelsky, mmirilovic |
Priority: | P1 | Keywords: | PERFORMANCE |
Version: | 3.x | ||
Hardware: | PC | ||
OS: | Windows ME/2000 | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 40229, 40231 | ||
Attachments: |
patch to ResultModel
patch to ResultViewTopComponent A patch for NB36 (trunk). |
Description
bwl
2004-02-26 06:16:22 UTC
Created attachment 13657 [details]
patch to ResultModel
Created attachment 13658 [details]
patch to ResultViewTopComponent
I will not apply the patch in the current form - it causes that search results are lost when the Search Results window is closed, which is undesirable. I appreciate your help with investigation of pending links to objects. It seems that the cause of the memory leak is that property change listener(s) are not unregestered. I agree. IMHO the close() method on the model should be called in setModel() of the ResultView component, not in componentClosed(). I am currently building sources with the patch. I will let you know how it works... Created attachment 13666 [details]
A patch for NB36 (trunk).
Marian, please review my patch. Profiler shows me that the resources are now cleaned correctly. I started after searching filesystems for "er" substring with 13570kB and after many searches (looking for "a", "e", "i", "o", ..., and at the end again for "er") with 13575 kB. And the number of TextDetail class instances, which used to grow and grow and grow, is now stable. Let me know, if you agree with the patch, and I will integrate it. THX. Yes, the patch looks good. You may integrate it. Thank you. Fix integrated in trunk. Brett, thanks for pointing this out and suggesting a fix! There is no problem to search repeatedly in build 200402261900. Verified. reopen to fix status and resolution fix status and resolution |