This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 32825

Summary:	upgrade.properties and backslash characters
Product:	installer	Reporter:	David Kaspar <dkaspar>
Component:	Code	Assignee:	issues@installer <issues>
Status:	VERIFIED FIXED
Severity:	blocker	CC:	ttran
Priority:	P1
Version:	3.x
Hardware:	PC
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Attachments:	diff of changes my upgr properties generated by today installater

Description David Kaspar 2003-04-11 11:07:01 UTC

Created upgrade.properties file in installed
netbeans root directory contains BACKUP_FOLDER.

For example on Windows value of this property
could be:
c:\myuserdir

But this is incorrect value because property
values must contain escaped backslash characters.

So correct value should be:
c:\\myuserdir

This problem arises only when you starting NB 3.5
for the first time with userdir specified by you
(-userdir parameter on command line).

Setting issue priority to P2 because on Windows
platform importing setting always fail in
described case.

Comment 1 Richard Gregor 2003-04-11 17:43:29 UTC

Created attachment 9893 [details]
diff of changes

Comment 2 Richard Gregor 2003-04-11 17:44:53 UTC

Fixed in main trunk.

Checking in src/org/netbeans/installer/actions/WriteAction.java;
/cvs/installer/src/org/netbeans/installer/actions/WriteAction.java,v 
<--  WriteAction.java
new revision: 1.13; previous revision: 1.12
done

Comment 3 _ ttran 2003-04-11 18:07:04 UTC

please ask someone from QA to verify the fix.  I'll approve shortly
once I see QA confirmation

Comment 4 Martin Entlicher 2003-04-14 08:45:05 UTC

Diff reviewed without objections, using Properties object will solve
this problem.

Comment 5 Milan Kubec 2003-04-14 12:10:16 UTC

Fix verified on dev build installer, approved.

Comment 6 _ ttran 2003-04-14 16:38:58 UTC

approved for 3.5 by release coordinator

Comment 7 Richard Gregor 2003-04-14 16:42:32 UTC

Fixed in release35.

Checking in src/org/netbeans/installer/actions/WriteAction.java;
/cvs/installer/src/org/netbeans/installer/actions/WriteAction.java,v 
<--  WriteAction.java
new revision: 1.11.2.2; previous revision: 1.11.2.1
done

Comment 8 dmladek 2003-04-15 07:17:57 UTC

IMHO, not sure if the fix is 100% reliable:-/

I took todays 3.5Beta installer
NetBeansIDE-release35-200304142350-win32.exe
and I've got this raw in the upgrade.properties file:
BACKUP_FOLDER=C\:\\Documents and Settings\\dm103276\\.netbeans\\3.4

but should be double slashed also the drive C: ?

What's your openion? Shell we reopen it?

Comment 9 dmladek 2003-04-15 07:19:05 UTC

Created attachment 9941 [details]
my upgr properties generated by today installater

Comment 10 David Kaspar 2003-04-15 09:08:00 UTC

Daniel,

Backslash character preceding colon character in your path is correct.

See javadoc for "store" method of "java.util.Properties" class:
http://java.sun.com/j2se/1.4.1/docs/api/java/util/Properties.html#store(java.io.OutputStream,
java.lang.String)

I think the fix works correctly.

Comment 11 dmladek 2003-04-15 10:38:34 UTC

Thanks David.
I wasn't sure about it. (and sorry my comment was unclear as I'm
reading it again)

so, I think we could mark it as verified