This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Looong time to display Generic VCS mounting wizard. | ||
|---|---|---|---|
| Product: | obsolete | Reporter: | Jiri Kovalsky <jkovalsky> |
| Component: | vcscore | Assignee: | Martin Entlicher <mentlicher> |
| Status: | VERIFIED FIXED | ||
| Severity: | blocker | Keywords: | PERFORMANCE |
| Priority: | P2 | ||
| Version: | -S1S- | ||
| Hardware: | PC | ||
| OS: | Windows ME/2000 | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Attachments: |
Several thread dumps taken during wizard invocation.
The binary patch. Put into <NB-install>/modules/autoload/patches/org-netbeans-modules-vcscore/ folder. The contextual diff, that fix this problem. Here are those exceptions ... Hm, probably this is what I should attach, I apologize ... :-( A new binary patch. Put into <NB-install>/modules/autoload/patches/org-netbeans-modules-vcscore/ folder. Attaching thread dump while invocation of the wizard ... A new binary patch. Put into <NB-install>/modules/autoload/patches/org-netbeans-modules-vcscore/ folder. The new contextual diff of the fix. |
||
|
Description
Jiri Kovalsky
2003-04-11 11:00:04 UTC
This is serious preformance regression. Created attachment 9870 [details]
Several thread dumps taken during wizard invocation.
Fixed in the main trunk, the object integrity support is initialized lazily not to block the filesystem instantiation: /cvs/vcscore/src/org/netbeans/modules/vcscore/objectintegrity/IntegritySupportMaintainer.java,v <-- IntegritySupportMaintainer.java new revision: 1.3; previous revision: 1.2 /cvs/vcscore/src/org/netbeans/modules/vcscore/objectintegrity/VcsObjectIntegritySupport.java,v <-- VcsObjectIntegritySupport.java new revision: 1.11; previous revision: 1.10 Created attachment 9904 [details]
The binary patch. Put into <NB-install>/modules/autoload/patches/org-netbeans-modules-vcscore/ folder.
Created attachment 9905 [details]
The contextual diff, that fix this problem.
I am sorry but this does not work. I got two exceptions and lost my filesystems. Created attachment 9908 [details]
Here are those exceptions ...
Created attachment 9910 [details]
Hm, probably this is what I should attach, I apologize ... :-(
Well, the first patch assumed some other patch which is already in the main trunk. I'm going to attach a new one, that should work with current NB 3.5 / S1S 5.0. Created attachment 9911 [details]
A new binary patch. Put into <NB-install>/modules/autoload/patches/org-netbeans-modules-vcscore/ folder.
Sorry, nothing has changed i.e. still takes looong time. :-) Created attachment 9912 [details]
Attaching thread dump while invocation of the wizard ...
Hmm, there is one more thing, that triggered the loading process. I'm going to improve the fix... So the initialization is done even more lazily. Fixed in the main trunk: /cvs/vcscore/src/org/netbeans/modules/vcscore/objectintegrity/VcsObjectIntegritySupport.java,v <-- VcsObjectIntegritySupport.java new revision: 1.12; previous revision: 1.11 Created attachment 9920 [details]
A new binary patch. Put into <NB-install>/modules/autoload/patches/org-netbeans-modules-vcscore/ folder.
Hm, this is great. I haven't noticed any performance delay at all ! Where did you Martin hide it ? Verified with the last version of the patch in development build #200304132350 of NetBeans 3.5. Created attachment 9923 [details]
The new contextual diff of the fix.
Code reviewed without objections. approved for 3.5 Thanks for the review, verification and approval. The problem is fixed in release35 branch: Checking in org/netbeans/modules/vcscore/objectintegrity/IntegritySupportMaintainer.java; /shared/data/helm/cvs/repository/vcscore/src/org/netbeans/modules/vcscore/objectintegrity/IntegritySupportMaintainer.java,v <-- IntegritySupportMaintainer.java new revision: 1.1.2.3; previous revision: 1.1.2.2 done Checking in org/netbeans/modules/vcscore/objectintegrity/VcsObjectIntegritySupport.java; /shared/data/helm/cvs/repository/vcscore/src/org/netbeans/modules/vcscore/objectintegrity/VcsObjectIntegritySupport.java,v <-- VcsObjectIntegritySupport.java new revision: 1.2.2.6; previous revision: 1.2.2.5 done Great, no performance degradation. Verified in Sun ONE Studio 5.0 Standard Edition build #030528. |