This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 32527

Summary: Creating ParserDB for folder w/out sources after project switch
Product: editor Reporter: Milan Kubec <mkubec>
Component: -- Other --Assignee: issues@editor <issues>
Status: VERIFIED FIXED    
Severity: blocker Keywords: PERFORMANCE
Priority: P1    
Version: -S1S-   
Hardware: All   
OS: All   
Issue Type: DEFECT Exception Reporter:
Attachments: Patch for release35. You can use -J-Dnetbeans.debug.editor.updater=true for testing with debug messages.

Description Milan Kubec 2003-04-01 09:40:02 UTC
IDE tries to create ParserDB after each switch of
project if the project contains mounted folder
without java sources, but with capability "Use in
Compiler" set to true. Any new folder (even empty)
which is mounted has this capability set to true.
It means that each such folder is searched
(parsed) after project switch *but* actual no
ParserDB is created, which results in parsing of
the same folder without sources again and again
after switching project. And also writing
meaningless message about parsing into Status line
after project switch.
Comment 1 Milan Kubec 2003-04-01 09:42:40 UTC
Can have performance impact if user has number of folders without java
sources mounted in project.
Comment 2 Martin Roskanin 2003-04-01 11:37:59 UTC
fixed in [maintrunk]

diff:
http://editor.netbeans.org/source/browse/editor/src/org/netbeans/modules/editor/java/JCUpdater.java.diff?r1=1.59&r2=1.60

Milan, if you think this bug deserves the integration into the
[release35], please increase the priority. The fix is simple. 
Comment 3 Milan Kubec 2003-04-01 12:06:23 UTC
Raising prio, because it has possible performance impact. Will verify
fix to be merged into release35.
Comment 4 Martin Roskanin 2003-04-01 15:02:39 UTC
Mila, could you please review the diff?
Eman, Milan could you please verify it in tomorrow build?
Thanks.
Comment 5 Milan Kubec 2003-04-02 08:36:23 UTC
I've verified the fix in today's trunk build, it can be merged into
release35.
Comment 6 ehucka 2003-04-02 08:54:51 UTC
It looks good in NB dev build 200304020100 on Linux with JDK 1.4.1_02.
It can be merged into release35.
Comment 7 Martin Roskanin 2003-04-02 10:19:55 UTC
To be precise, I am attaching the patch for release35 also.
Eman could you please, test it?
Copy the attached JCUpdater.jar to
<NB-install>/modules/patches/org-netbeans-modules-editor folder. Thanks.


Comment 8 Martin Roskanin 2003-04-02 10:21:33 UTC
Created attachment 9647 [details]
Patch for release35. You can use -J-Dnetbeans.debug.editor.updater=true for testing with debug messages.
Comment 9 Milan Kubec 2003-04-02 12:02:56 UTC
Patch verified by QA for nevada (release35).
Comment 10 Miloslav Metelka 2003-04-02 12:16:30 UTC
I have reviewed the fix and it should be OK.
Comment 11 ehucka 2003-04-02 14:01:48 UTC
Verified in NB 3.5 20030401235 on Linux.
Comment 12 _ ttran 2003-04-04 11:02:35 UTC
approved for 3.5
Comment 13 Martin Roskanin 2003-04-04 11:15:35 UTC
integrated into [release35]

/cvs/editor/src/org/netbeans/modules/editor/java/JCUpdater.java,v  <--
 JCUpdater.java
new revision: 1.56.2.3; previous revision: 1.56.2.2
Comment 14 Milan Kubec 2003-07-11 13:40:19 UTC
Verified.