This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Patch in support for 26640 (in module apisupport/lite) | ||
---|---|---|---|
Product: | obsolete | Reporter: | _ mihmax <mihmax> |
Component: | apisupport | Assignee: | _ mihmax <mihmax> |
Status: | RESOLVED INVALID | ||
Severity: | blocker | Keywords: | I18N |
Priority: | P3 | ||
Version: | 3.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | TASK | Exception Reporter: | |
Attachments: | Patch file |
Description
_ mihmax
2003-02-22 21:36:10 UTC
Created attachment 9099 [details]
Patch file
Please clean this up some first. 1. There are some diffs to .form files which do nothing at all, just reorder some properties meaninglessly. (See issue #3584.) Similarly, some patch blocks in .java just reorder statements meaninglessly, though this is less annoying I think since at least the diff to that file includes some useful changes. 2. What is this? - // Variables declaration - do not modify//GEN-BEGIN:variables + // ?????????? ?????????? - ?? ????????? ?????? ???//GEN-BEGIN:variables Something in Russian? 3. (Most important) When you have a diff like this: - versionLabel.setText(java.util.ResourceBundle.getBundle("org/netbeans/modules/apisupport/lite/Bundle").getString("LBL_Version")); + org.openide.awt.Mnemonics.setLocalizedText(versionLabel,java.util.ResourceBundle.getBundle("org/netbeans/modules/apisupport/lite/Bundle").getString("LBL_Version")); Fine, but what happens the next time a developer opens this form in the Form Editor? This change is immediately reverted with no warning, since the .form file still says this: <Property name="text" type="java.lang.String" editor="org.netbeans.modules.i18n.form.FormI18nStringEditor"> <ResourceString bundle="org/netbeans/modules/apisupport/lite/Bundle.properties" key="LBL_Version" replaceFormat="java.util.ResourceBundle.getBundle("{bundleNameSlashes}").getString("{key}")"/> </Property> You need to change both the .java and .form in parallel. 4. When changing the format of a bundle key, e.g. taking a label and a separate mnemonic and merging them into a key which contains a label with an ampersand, you need to use a fresh key name. Otherwise the localization team (Japanese e.g.) might just see that LBL_Version_Mnemonic is missing in the English bundle, delete it in the Japanese bundle, and not notice that the Japanese version of LBL_Version is now expected to include an inline mnemonic too. After resolution of issue 27009 the patch will be absolutely different, so closing this as INVALID so far. |