This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | BinaryFS doesn't behave like XMLFileSystem | ||
---|---|---|---|
Product: | platform | Reporter: | Vitezslav Stejskal <vstejskal> |
Component: | Module System | Assignee: | Jesse Glick <jglick> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | ||
Priority: | P1 | ||
Version: | 3.x | ||
Hardware: | PC | ||
OS: | All | ||
Issue Type: | TASK | Exception Reporter: | |
Bug Depends on: | 29382 | ||
Bug Blocks: | 20628 | ||
Attachments: | patch for BinaryFS class |
Description
Vitezslav Stejskal
2002-12-06 13:45:10 UTC
Created attachment 8193 [details]
patch for BinaryFS class
This will require a unit test too - whoever put in the original hack did not bother to write a test for it. Hey, you caught me :-). Well, I'll write these tests. IMO two tests are needed; first testing XMLFileSystem pluged into the MultiFileSystem which will test that MFO is passed to method invoked from methodvalue attribute implementation. Second test should be written to ensure that this still works for module layer and DefaultFileSystem. The first one should be quite easy, however I am unclear how to write the second one. Could you advice me how to create module just for test or how to plug layer into DFS from test? Don't worry, I managed to write such a test, and confirmed that it passes for the binary cache manager if and only if your patch is applied. I opened issue #29382 to try to get rid of this kind of reflection stuff ASAP. I patched CacheManagerTestBaseHid, meaning all cache manager impls are tested, so this automatically tests XMLFileSystem (via XMLLayerCacheManagerImpl and NonCacheManager) as well as BinaryFS. committed * Up-To-Date 1.12 core/src/org/netbeans/core/projects/FixedFileSystem.java committed * Up-To-Date 1.3 core/src/org/netbeans/core/projects/cache/BinaryFS.java committed * Up-To-Date 1.2 core/test/unit/src/org/netbeans/core/projects/cache/CacheManagerTestBaseHid.java committed * Up-To-Date 1.2 core/test/unit/src/org/netbeans/core/projects/cache/data/layer1.xml |