This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 28404

Summary: RMIWizardX wizard panels hurts performance
Product: obsolete Reporter: David Simonek <dsimonek>
Component: rmiAssignee: akemr <akemr>
Status: RESOLVED FIXED    
Severity: blocker Keywords: PERFORMANCE
Priority: P2    
Version: 3.x   
Hardware: PC   
OS: All   
Issue Type: DEFECT Exception Reporter:
Bug Depends on:    
Bug Blocks: 27795    

Description David Simonek 2002-11-01 16:36:10 UTC 
WizardDescriptor.Panel implementation
RMIWizard2 provides itself as the
result of getComponent().
This hurts performance and can cause a clash when
Component.isValid() is overridden.
Please use a separate component class, see details
at
http://performance.netbeans.org/howto/dialogs/wizard-panels.html.

Easy to fix, P2 justification - performance is top
priority.
Comment 1 David Simonek 2002-11-04 15:37:05 UTC 
Similar situation in
org\netbeans\modules\rmi\wizard\RMIWizard3.java 
org\netbeans\modules\rmi\wizard\RMIWizard4.java 
Please fix them as well, thanx.
Comment 2 David Simonek 2003-01-24 13:53:47 UTC 
Guys, there was an error in example code in IDESettingsWizardPanel.java.
Please check your fix and repair if you did the same mistake. I'm terribly
sorry, but I'm only a human :-)
Please read details below:

---------------------------------
  Modified:    src/org/netbeans/core/ui IDESettingsWizardPanel.java
  Log:
  fix for incorrect assumption that getComponent
  must be called before readSettings.
  Now they can be called in any order.
  
  Revision  Changes    Path
  1.3       +2 -2      core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java
  
 
http://core.netbeans.org/source/browse/core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java.diff?r1=1.2&r2=1.3
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: IDESettingsWizardPanel.java
  ===================================================================
  RCS file: /cvs/core/src/org/netbeans/core/ui/IDESettingsWizardPanel.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -b -r1.2 -r1.3
  --- IDESettingsWizardPanel.java	2002/12/03 14:10:35	1.2
  +++ IDESettingsWizardPanel.java	2003/01/24 13:45:30	1.3
  @@ -7,7 +7,7 @@
    * http://www.sun.com/
    * 
    * The Original Code is NetBeans. The Initial Developer of the Original
  - * Code is Sun Microsystems, Inc. Portions Copyright 1997-2001 Sun
  + * Code is Sun Microsystems, Inc. Portions Copyright 1997-2003 Sun
    * Microsystems, Inc. All Rights Reserved.
    */
   
  @@ -42,7 +42,7 @@
       */
       public void readSettings (Object settings) {
           if (settings instanceof WizardDescriptor) {
  -            panelUI.initFromSettings((WizardDescriptor)settings);
  +            getPanelUI().initFromSettings((WizardDescriptor)settings);
           }
       }
Comment 3 akemr 2003-02-18 14:18:16 UTC 
I'll look at it
Comment 4 akemr 2003-02-20 12:15:14 UTC 
Fixed in trunk.