This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | code indentation broken when I push down the opening curly bracket of a method | ||
---|---|---|---|
Product: | php | Reporter: | par7133 |
Component: | Formatting & Indentation | Assignee: | junichi11 |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | junichi11, tmysik |
Priority: | P3 | ||
Version: | 8.2 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
IDE log
after before |
Description
par7133
2016-10-20 23:10:58 UTC
Created attachment 162578 [details]
IDE log
Created attachment 162579 [details]
after
Created attachment 162580 [details]
before
Thanks for reporting. Fixed. http://hg.netbeans.org/web-main/rev/3d716a8ca6a2 Tomas, PHPFormatter.reindent was invoked twice(It means that an indentation may be broken. Actually, my fix was broken). So, I also checked Context.mimePath(). One MimePath of Context has text/javascript as a mimeType when I debug it. Thanks! (In reply to junichi11 from comment #5) > Tomas, PHPFormatter.reindent was invoked twice(It means that an indentation > may be broken. Actually, my fix was broken). So, I also checked > Context.mimePath(). One MimePath of Context has text/javascript as a > mimeType when I debug it. So, should we report a bug against JavaScript? Or..? Anyway, thanks for the fix, Junichi! (In reply to Tomas Mysik from comment #6) > So, should we report a bug against JavaScript? Or..? Probably, I think that it's no problem because we can avoid that. I just wanted to let you know the reason for my change :) Just information: It seems that Html and CSS use the specific class(CssIndentTask, HtmlIndentTask). Other than that(JS, PHP) use GsfIndentTask. > Anyway, thanks for the fix, Junichi! You are welcome :) (In reply to junichi11 from comment #7) > Probably, I think that it's no problem because we can avoid that. I just > wanted to let you know the reason for my change :) So, if you have a reproducible use case, feel free to report it, please. Thanks! (In reply to Tomas Mysik from comment #8) > So, if you have a reproducible use case, feel free to report it, please. I see. Thanks! Integrated into 'main-silver', will be available in build *201611090620* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/3d716a8ca6a2 User: Junichi Yamamoto <junichi11@netbeans.org> Log: #268621 - code indentation broken when I push down the opening curly bracket of a method |