This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | AssertionError thrown when using org.netbeans.modules.localhistory.ui.actions.RevertDeletedAction | ||
|---|---|---|---|
| Product: | versioncontrol | Reporter: | sproger1 |
| Component: | Localhistory | Assignee: | Tomas Stupka <tstupka> |
| Status: | RESOLVED INCOMPLETE | ||
| Severity: | normal | CC: | sproger1 |
| Priority: | P1 | ||
| Version: | 8.2 | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Attachments: | Full Netbeans IDE log | ||
|
Description
sproger1
2016-07-13 15:30:30 UTC
There is a high probability that more Action classes (those that extend NodeAction) in the Dev build (after 5 May 2016 due to commits by Jaroslav Tulach on 5 May hg rev# 169964 and/or rev#169962) have this same bug, if said actions do not explicitly set asynchronous to false, and they create/launch ui/swing/awt... objects. The default of asynchronous = false has somehow changed, since RevertDeletedAction has not been modified and it used to work before. Some underlying behaviour has changed that is causing this issue, and hence I think it is not enough to simply fix this RevertActionDeleted class but also to check/fix the underlying issue (i.e. verify that ALL actions that require asyncronous=false are indeed setting the property). fixed in jet-main #673a47796c3c > There is a high probability that more Action classes (those that extend NodeAction) ... there probably will be more cases than just the mentioned actions > I think it is not enough to simply fix this RevertActionDeleted class but also ... guess that it was one of the ideas of the assert being set - to identify the relevant cases, report and fix them Thanks for the quick response. I verified/tested your commit and it does fix the problem for the RevertDeletedAction. I understand, that the current approach is to report and fix as needed. Just wish there was some automated UI testing that would exersise all the Action classes so that your user's don't experience so many bugs that could be caught by regression testing. I understand that this is likely due to limited resources, and also the scope and length of time it would take to run such tests. Just nit picking :) . I will do my best to report any I encounter, and thanks again for the quick fix. With the fix (jet-main #673a47796c3c), I'm still bombarded with the warning message: WARNING [org.openide.util.actions.CallableSystemAction]: Warning - org.netbeans.modules.localhistory.ui.actions.RevertDeletedAction should override CallableSystemAction.asynchronous() to return false Why does it give this message and it still thing asynchronous should be set to false? Other than the warning, it works fine. Can you make the message go away by explicitly setting asynchronous to true? Almost complete, please make warning message go away, see previous comment Integrated into 'main-silver', will be available in build *201607140002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/673a47796c3c User: Tomas Stupka <tstupka@netbeans.org> Log: Issue #262802 - AssertionError thrown when using org.netbeans.modules.localhistory.ui.actions.RevertDeletedAction |