This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Evaluate why certain Actions are not logged | ||
---|---|---|---|
Product: | editor | Reporter: | Geertjan Wielenga <geertjan> |
Component: | Actions/Menu/Toolbar | Assignee: | Miloslav Metelka <mmetelka> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | anebuzelsky, geertjan, issues, jtulach, markiewb, mbalin, ralphbenjamin |
Priority: | P2 | ||
Version: | 8.1 | ||
Hardware: | PC | ||
OS: | Windows 7 | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
Geertjan Wielenga
2016-07-07 09:17:55 UTC
Certain actions are used internally e.g. for tooltip building and also kit-install actions could be performed at the editor kit installation into editor component so I should retain their exclusion. On the other hand if you think that all the caret movements and selections should be logged I can comment out the exclusions. Not sure about about logging all the typed characters by the "default-typed" action I'll leave it excluded for now. Let's try and we will and we will see if it will be ok or not. http://hg.netbeans.org/jet-main/rev/8bf4d31f56e0 Integrated into 'main-silver', will be available in build *201608270002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/8bf4d31f56e0 User: Miloslav Metelka <mmetelka@netbeans.org> Log: #262714 - Evaluate why certain Actions are not logged. Thanks very much, much better. Only multi-caret mode doesn't seem to be captured, can that be included too? Geertjan, Mila, I think we previously filtered these actions, because otherwise during usual typing activity we had two problems: - huge uigestures file with actions which are not analysed anyway - big I/O activity in parallel to editing file which is a problem at least when userdir at network home (again without real reason) If you really need it for your plug-in it's worth to introduce some flag (System.getProperty in editor setProperty in your plug-in?). But please, do not slowdown the general IDE editor with I/O Sure, that property makes perfect sense. (In reply to Vladimir Voskresensky from comment #5) > If you really need it for your plug-in it's worth to introduce some flag > (System.getProperty in editor setProperty in your plug-in?). But please, do > not slowdown the general IDE editor with I/O Adding a property to intentionally break the ide doesn't sound good. Is it possible for the uigestures-file-writer, to filter what it writes? Or can we introduce a second logging channel for actions not to be included in the uigestures file? For now I would create a system property that, when turned on, would include the logging of the extra actions added by the last patch. We can add a more elaborate solution later. Can it be like this? org.netbeans.editor.ui.actions.logging.detailed=true Perfect. Property added in http://hg.netbeans.org/jet-main/rev/8f112f9b30fb Integrated into 'main-silver', will be available in build *201609070002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/8f112f9b30fb User: Miloslav Metelka <mmetelka@netbeans.org> Log: #262714 - Evaluate why certain Actions are not logged - added org.netbeans.editor.ui.actions.logging.detailed system property. |