This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 257823

Summary:	Bug 246199 - Notifications window link color is hardcoded has not been integrated into NB8.1
Product:	platform	Reporter:	markiewb
Component:	Notifications	Assignee:	Jan Peska <JPESKA>
Status:	VERIFIED INVALID
Severity:	normal	CC:	markiewb
Priority:	P3
Version:	8.1
Hardware:	PC
OS:	Windows 7
Issue Type:	DEFECT	Exception Reporter:
Attachments:	Shows the manifest, the history and its content

Description markiewb 2016-02-02 21:29:15 UTC

Created attachment 158357 [details]
Shows the manifest, the history and its content

"Bug 246199 - Notifications window link color is hardcoded" has not been integrated properly into NB8.1. It has been integrated in main-silver before NB8.1 release, but it never worked. See [1]

Perhaps someone forgot to update the module version or something like that?
When starting NB8.1 	
org.netbeans.modules.notifications [1.7.1 201510222201]
is shown, but IMO it has to be at least 1.8.

[1] https://github.com/Revivius/nb-darcula/issues/65

Comment 1 Martin Entlicher 2016-02-04 12:31:22 UTC

I've verified that the Ondra's fix http://hg.netbeans.org/core-main/rev/c4d4842bf316 is in release81 branch. It was likely pushed before release81 branch was created.

If the problem still appears in NB 8.1, it means that the change did not solve the problem. The actual commit differs from the attached patch, therefore it's possible that it does not in fact fix the issue.

I'm closing this as invalid, since the module version is not an issue. If the bug persists, bug #246199 should be reopened.

Comment 2 markiewb 2016-02-04 19:34:04 UTC

@Martin: Thanks for checking!

You are correct. Regarding http://forums.netbeans.org/viewtopic.php?p=168760 there is another implementation of NotificationImpl in core.ui, which is still faulty.

http://hg.netbeans.org/main-silver/file/426ac2a45600/core.ui/src/org/netbeans/core/ui/notifications/NotificationImpl.java#l198

Comment 3 Jiri Kovalsky 2016-02-04 20:01:46 UTC

Verifying as invalid issue. Thanks for the heads-up Benno!

Comment 4 Revivius 2016-02-04 20:42:47 UTC

Should I create a different issue for core.ui NotificationImpl ?

http://hg.netbeans.org/main-silver/file/426ac2a45600/core.ui/src/org/netbeans/core/ui/notifications/NotificationImpl.java#l198

Comment 5 Martin Entlicher 2016-02-04 21:30:29 UTC

Please write the comments about two implementations into bug #246199 so that it does not get lost.
IMHO that one bug is fine for both problematic locations.