This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Use Kwallet5 for passwords | ||
---|---|---|---|
Product: | platform | Reporter: | guoyunhebrave |
Component: | Keyring | Assignee: | Tomas Mysik <tmysik> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | emi, hlavki, lfischmeistr, tmysik |
Priority: | P3 | ||
Version: | 8.1 | ||
Hardware: | PC | ||
OS: | Linux | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | Implement KWallet5Provider |
Description
guoyunhebrave
2015-11-15 13:31:21 UTC
Created attachment 161716 [details]
Implement KWallet5Provider
I've created simple patch for this issue
Based on [1], the current state is:- KDE 5 has a new version of KWallet due to QT incompatible change (In reply to Tomas Mysik from comment #2) > Based on [1], the current state is:- KDE 5 has a new version of KWallet due > to QT incompatible change Ignore this comment, BZ session timeout occured :/ Based on [1], the current state is: - KDE 5 has a new version of KWallet due to QT incompatible change; - KDE 4 KWallet works on systems that has been upgraded to KDE 5 (KWallet data are migrated); - KDE 4 KWallet does not work on clean installations of KDE 5 systems. I will fix this issue by using KDE 5 KWallet with a fallback to KDE 4 one. Also, I will provide a way to easily specify a different KWallet "version" (e.g. "version" 6, via system property) so possible future changes in this area can be easily solved even in the stable versions of NetBeans. Thanks for reporting. [1] https://barlog.rusu.info/valentin/blog/?p=300 > I will fix this issue by using KDE 5 KWallet with a fallback to KDE 4 one.
Attached patch do the same.
(In reply to hlavki from comment #5) > > I will fix this issue by using KDE 5 KWallet with a fallback to KDE 4 one. > > Attached patch do the same. No, it does not. But thanks for it, of course. Tomas, if your idea is to search for password in kwallet5 and if entry will not be found, than fallback to kwallet4, then I think it's bad idea. Please, be more specific. (In reply to hlavki from comment #7) > Tomas, if your idea is to search for password in kwallet5 and if entry will > not be found, than fallback to kwallet4 No, it is not. Please, wait for the fix and then feel free to review it. Will do it on Thursday, need to verify it on KDE 4 first. Thanks. Anyway attached patch only adds new class Kwallet5Provider. Diff view in bugzilla is not correct. KwalletProvider for KDE 4 is still there! Should be fixed now. Prefer KDE 5 with fallback to KDE 4. Also provide a way to specify custom KWallet versions (via system property). Thanks. http://hg.netbeans.org/web-main/rev/d5f1f8b1aae0 Same idea, different implementation, but looks good ;) Would be great if you/anyone could verify it. Thanks! I can confirm that KWallet5 integration works. I'll try v4 later. Integrated into 'main-silver', will be available in build *201609020002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/d5f1f8b1aae0 User: Tomas Mysik <tmysik@netbeans.org> Log: #256606 - Use Kwallet5 for passwords Prefer KDE 5 with fallback to KDE 4. Also provide a way to specify custom KWallet versions (via system property). Great to hear, thank you. |