This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Grails Platform version detection not working for Grails 3. | ||
---|---|---|---|
Product: | groovy | Reporter: | bruno.flavio |
Component: | Grails | Assignee: | bruno.flavio |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | bruno.flavio, jkovalsky |
Priority: | P3 | ||
Version: | 8.1 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 255967 | ||
Attachments: | Proposed patch: when the build.properties approach fails invoke the grails command to get the version. |
Description
bruno.flavio
2015-10-24 22:37:08 UTC
Created attachment 156956 [details]
Proposed patch: when the build.properties approach fails invoke the grails command to get the version.
The proposed patch invokes the "grails --version" command when the build.properties file is not available.
This approach works for both grails 2 and 3. However, it requires the JDK home variable of NetBeans to be passed to the command, and not the project defined one. I don't think it'll be a problem, however it should be tested in other platforms.
Patch applied to core-main: http://hg.netbeans.org/core-main/rev/cc6f46b7f174 Setting Target Milestone accordingly. Integrated into 'main-silver', will be available in build *201512160002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/cc6f46b7f174 User: Bruno Fl The platform detection is used internally and currently can only be verified indirectly: The fact that the dependent #255967 works for both grails 2 and 3 confirms that platform version detection is working. Because the dependent #255957 resolves the inability to debug grails 2 and 3 applications this should be included in the 8.1 Patch 1. Bruno, can you please integrate this fix to release81 branch by 1/31? Thanks! (In reply to Jiri Kovalsky from comment #6) > Bruno, can you please integrate this fix to release81 branch by 1/31? Thanks! Sure. I'll integrate the fix and upgrade the relevant module versions by Friday. The fix has been applied to the release81 branch. Thanks Bruno. Do you have changeset number? (In reply to Jiri Kovalsky from comment #9) > Thanks Bruno. Do you have changeset number? Sorry, here it is: Fix: http://hg.netbeans.org/releases/rev/2f6e6260bed4 Spec version and message update: http://hg.netbeans.org/releases/rev/e6a78d0b0996 I know the issue is fixed. But just for knowledge, there is gradle.properties file which provides this info. Here are the contents of it for my application: grailsVersion=3.0.11 gradleWrapperVersion=2.3 (In reply to ejaz_ahmed from comment #11) > I know the issue is fixed. But just for knowledge, there is > gradle.properties file which provides this info. Here are the contents of it > for my application: > > grailsVersion=3.0.11 > gradleWrapperVersion=2.3 Hello, I think that using the gradle.properties file will lead to a better solution. Would you please open a new issue for this? Thank you for your help, -Bruno Yah, sure. |