Bug 254445

In many cases 'The if statement is redundant' message is good advice, but there are some cases where the code is MUCH clearer by intentionally using the redundant 'if'.

That's why it should be possible to suppress the warning using @SuppressWarnings for these cases in order not to have to disable the warning globally. It has its merits and should be enabled in general.

Example for a case where suppressing the warning would be appropriate and best choice in my opinion:


public boolean matches(Item item)
{
   if (!doesDetailMatch(item.getDetail1(), 'a')) return false;
   if (!doesDetailMatch(item.getDetail2(), 'b')) return false;
   if (!doesDetailMatch(item.getDetail3(), 'c')) return false;
   if (!doesDetailMatch(item.getDetail4(), 'd')) return false;

   if (!doesDetailMatch(item.getDetail5(), 17)) return false;
   if (!doesDetailMatch(item.getDetail6(), 20)) return false;
   if (!doesDetailMatch(item.getDetail7(), -5)) return false;

   return true;
}


In this example the last 'if' statement is marked as redundant, which is technically correct, but in this kind of case it's obvious why you want to keep it that way. Please make the warning suppressable by annotation.

Thank you.

PS: Other posters have pointed out similar examples, just in a different contexts, for example #247780 and #238286 (at the end). I think they'd also appreciate the feature. Thanks again.