This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Notifications window link color is hardcoded. | ||
|---|---|---|---|
| Product: | platform | Reporter: | venkatramakkineni <venkatramakkineni> |
| Component: | Notifications | Assignee: | markiewb |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | saubrecht, venkatramakkineni |
| Priority: | P3 | Keywords: | NETFIX, PATCH_AVAILABLE |
| Version: | 8.1 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Attachments: |
Image demostrating the problem
A patch that uses the nb.html.link.foreground as the color of the link. A patch that uses the nb.html.link.foreground as the color of the link. |
||
Created attachment 148480 [details]
A patch that uses the nb.html.link.foreground as the color of the link.
Created attachment 148482 [details]
A patch that uses the nb.html.link.foreground as the color of the link.
Removed the hard coded link color in Notifications Details panel and started using the color specification in nb.html.link.foreground. This lets the third party LAF developers to customize the link foreground.
Integrated into 'main-silver', will be available in build *201509130002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/c4d4842bf316 User: Ondrej Vrabec <ovrabec@netbeans.org> Log: #246199 - Notifications window link color is hardcoded. This issue was not verified yet and according to bug #257823, this fix is not sufficient. As far as I can see there are two NotificationImpl classes: 1. One is in notifications module and was fixed in this issue. 2. There is another one in core.ui and it also uses hardcode link color: http://hg.netbeans.org/main-silver/file/426ac2a45600/core.ui/src/org/netbeans/core/ui/notifications/NotificationImpl.java#l198 I would like to suggest: - apply same fix there (use "nb.html.link.foreground") Or - move common NotificationImpl code to openide.awt (though I am not sure core.ui can depend on openide.awt safely) and let notifications module version extend common one. Fixed http://hg.netbeans.org/core-main/rev/3055beb59589 Applied same fix there (use "nb.html.link.foreground") at core.ui/src/org/netbeans/core/ui/notifications/NotificationImpl.java Integrated into 'main-silver', will be available in build *201607190002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/3055beb59589 User: Benno Markiewicz <markiewb@netbeans.org> Log: #246199 - Notifications window link color is hardcoded |
Created attachment 148478 [details] Image demostrating the problem In the Notifications TopComponent, the links in Notification Detail Panel are hard code. This makes them unreadable on darker look and feels. Please refer to the attached image for more detail.