This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 244744

Summary:	Get rid of openide.text dependencies
Product:	java	Reporter:	Svata Dedic <sdedic>
Component:	Source	Assignee:	Svata Dedic <sdedic>
Status:	RESOLVED FIXED
Severity:	normal	CC:	dbalek, issues, marfous, mmetelka
Priority:	P3	Keywords:	API, API_REVIEW_FAST
Version:	8.0
Hardware:	PC
OS:	Linux
Issue Type:	TASK	Exception Reporter:
Bug Depends on:
Bug Blocks:	247200

Description Svata Dedic 2014-05-27 13:25:06 UTC

A few references to openide.text API is still in java.source.base - NbDocument and PositionRef.
According to offline discussion, PositionRef can be removed from the API (with some provisions for backward binary compatibility), NbDocument services can be replaced by other APIs introduced recently in editor.document module.

The API change (compatible) is that org.openide.text.PositionRef will implement j.s.t.Position directly (discussed with Tomas Z.) - this allows compatibility bridges to extract necessary data for old clients.

Change is to be committed into server_split jet-main branch.

Comment 1 Svata Dedic 2014-05-28 07:27:20 UTC

Additional fixes were necessary in:

* j2ee.ejbverification/src/org/netbeans/modules/j2ee/ejbverification/fixes/ExposeBusinessMethod.java
* websocket/src/org/netbeans/modules/websocket/editor/WebSocketMethodsTask.java 

Please review whether the fix is acceptable - saving the file (verification) may now be even unnecessary.


Implemented in jet-main#733fc267c72e (branch server_split)

Comment 2 Martin Fousek 2014-05-28 11:32:45 UTC

Thanks Svato for the code change, looks well, just one note ...

Shouldn't be there (2.26):
docToSave = target.getLookup().lookup(CloneableEditorSupport.class);
instead of:
target.getLookup().lookup(CloneableEditorSupport.class);

Comment 3 Svata Dedic 2014-05-28 11:48:55 UTC

(In reply to Martin Fousek from comment #2)
> Thanks Svato for the code change, looks well, just one note ...
> 
Very, very politely said :) Thanks for the review -- hopefully will be fixed in jet-main#9b968f378c77

Comment 4 Quality Engineering 2014-10-18 05:12:34 UTC

Integrated into 'main-silver', will be available in build *201410180001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/733fc267c72e
User: Svata Dedic <sdedic@netbeans.org>
Log: #244744: openide.text dependency removed from java.source.base, clients updated