This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 241638

Summary:	Disable "Finish" button if additional properties UI is not yet shown
Product:	projects	Reporter:	Denis Anisimov <ads>
Component:	Maven	Assignee:	Tomas Stupka <tstupka>
Status:	RESOLVED WONTFIX
Severity:	normal
Priority:	P3
Version:	7.4
Hardware:	PC
OS:	Windows 7
Issue Type:	DEFECT	Exception Reporter:

Description Denis Anisimov 2014-02-10 12:47:45 UTC

Maven->Project from Archetype wizard last page "Name and Location"
shows additional creation properties (it could show if there are any).

Properties are identified in the separate thread and UI is shown when properties are collected.

At the very first time the latter UI panel is not shown immediately. It takes some time to run the thread where the properties are collected.

If there are required properties then it's easy to finish the wizard which will fail in the result because of lack of necessary properties.

The solution is:
make wizard invalid until properties are not collected.
Then notify the wizard listeners and make wizard valid when properties are collected. Additional properties UI could be not visible if there are no required properties.
But "Finish" button should be disabled until information about properties not available.
No need to add any error messages here.
This issue is related to the  #241637.

Comment 1 Milos Kleint 2014-02-10 13:03:19 UTC

I agree this is suboptimal, but do we want to really stop people finish the wizard until we manage to download and parse the archetype descriptor?

Most archetypes don't have any additional props and if they do, they mostly have (IMHO should have) default values.
The maven failure output is somewhat descriptive (see my comment in issue 241637)
Next time around when user selects the archetype, the panel will load the props immediately.

So I'm not entirely sure that for the good of few we should make the experience worse for everyone. (by waiting for the archetype to download)

Comment 2 Denis Anisimov 2014-02-10 19:11:11 UTC

(In reply to Milos Kleint from comment #1)
> I agree this is suboptimal, but do we want to really stop people finish the
> wizard until we manage to download and parse the archetype descriptor?
> 
> Most archetypes don't have any additional props and if they do, they mostly
> have (IMHO should have) default values.
> The maven failure output is somewhat descriptive (see my comment in issue
> 241637)
> Next time around when user selects the archetype, the panel will load the
> props immediately.
> 
> So I'm not entirely sure that for the good of few we should make the
> experience worse for everyone. (by waiting for the archetype to download)

Well, yes. That's also true.

But as I've commented in the issue #241637: unexperienced user is not able to understand the reason of the failure. 

But I'm not sure about the best approach here....

Comment 3 Martin Balin 2016-07-07 08:38:26 UTC

This old bug may not be relevant anymore. If you can still reproduce it in 8.2 development builds please reopen this issue.

Thanks for your cooperation,
NetBeans IDE 8.2 Release Boss