Bug 239397

Created attachment 143088 [details]
snapshot of the refactoring

While i can see howcome the decition to update the instant inline rename of fields and methods in a java class to be bound into the refactoring framework (and thus allow for stuff like renaming comments and the like) it simply is just an annoyance to me. 

If i hit "ctrl + r" on a private field to rename it, every instance of the field is encapsulated in a box and are changed when i update the name. 
Before the new refactor-rename functionality you would hit enter, the encapsulating box would be removed and the field is renamed.

Now after the refactor rename, the field name is changed back to what it were, and the refactoring is calculating dependencies, finding usages, setting up and whatever else it has to do before renaming the field.
All in all it easily takes up 5 seconds of, what is essentially nothing, as the field had already been renamed before the refactoring dialog popped up.

I don't suggest removing this new functionality, but if performance can not be dramatically improved, i would like an option to turn it of and just leave the field renamed as it used to be.


Heres an example:

public class NewClass {
	private String p;

	public NewClass() {
		p = "";
	}	
}

in the constructor i put the cursor on the "p" field and hit "ctrl + r" and type in another name for the field (not hitting "Enter").
The field is now essentially renamed (its a private field) as all occurences of it has been given the new name.

Hitting enter, it then takes 4-5 seconds to "refactor" the code...