This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Rename refactor can break code when new name shadows existing name | ||
|---|---|---|---|
| Product: | java | Reporter: | David Strupl <dstrupl> |
| Component: | Refactoring | Assignee: | Ralph Ruijs <ralphbenjamin> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | briangoetz, dbalek |
| Priority: | P3 | ||
| Version: | 7.3 | ||
| Hardware: | PC | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
changeset : 0067029ba850 author : Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org> date : Tue Jan 07 16:02:27 CET 2014 summary : #235564 - Rename refactor can break code when new name shadows existing name Integrated into 'main-silver', will be available in build *201401090002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/0067029ba850 User: Ralph Benjamin Ruijs <ralphbenjamin@netbeans.org> Log: #235564 - Rename refactor can break code when new name shadows existing name |
This report is about the remaining case from bug report #104551. This happens with all kinds of variables, not just local variables. For example: public class Foo { public int x; public class Inner { public int y; public void foo() { y = x + 1; } } } Again, renaming y to x in the inner class, Netbeans changes the assignment, changing the semantics of the code, to: x = x + 1; where the right answer is: x = Foo.this.x + 1;