This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 233096

Summary:	org.netbeans.modules.php.editor.js.JsFormatterEmbeddedTest failing
Product:	javascript	Reporter:	Petr Hejl <phejl>
Component:	Formatting & Indentation	Assignee:	Petr Hejl <phejl>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mfukala, mkristofic, obrejla, sdedic
Priority:	P2	Keywords:	TEST
Version:	7.4
Hardware:	PC
OS:	All
Issue Type:	DEFECT	Exception Reporter:

Description Petr Hejl 2013-07-19 21:22:16 UTC

Failing since Marek's changes I guess. Reminder for me to evaluate and fix. Tests are commented out for now.

Comment 1 Quality Engineering 2013-07-21 02:16:58 UTC

Integrated into 'main-silver', will be available in build *201307202300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/a01c273d4db0
User: Petr Hejl <phejl@netbeans.org>
Log: #233096 - org.netbeans.modules.php.editor.js.JsFormatterEmbeddedTest failing

Comment 2 Petr Hejl 2013-07-23 09:29:35 UTC

Should be fixed in web-main 8d8c3f1f2865. I had to change GsfReformatTask because the JSFormatter would not have been called otherwise. It checked only the first embedding level. Hopefully it is ok.

Comment 3 Quality Engineering 2013-07-24 02:36:44 UTC

Integrated into 'main-silver', will be available in build *201307232300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)

Changeset: http://hg.netbeans.org/main-silver/rev/8d8c3f1f2865
User: Petr Hejl <phejl@netbeans.org>
Log: #233096 - org.netbeans.modules.php.editor.js.JsFormatterEmbeddedTest failing