This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 230812

Summary:	[Select Next Element] Revert line selection because of selection issues and usability
Product:	java	Reporter:	markiewb
Component:	Editor	Assignee:	Dusan Balek <dbalek>
Status:	VERIFIED FIXED
Severity:	normal	Keywords:	USABILITY
Priority:	P3
Version:	7.4
Hardware:	PC
OS:	Windows 7
Issue Type:	DEFECT	Exception Reporter:
Attachments:	Proposed patch, which removes the line selection code Shows the issue with if conditionals, it doesn't widen the selection

Description markiewb 2013-06-05 22:39:20 UTC

[ BUILD # : 201305262300 ]
[ JDK VERSION : 1.7.0_21 ]

A simple implementation of line selection in "Select Next Element" was
introduced by [1].

This looked good at the time of implementation, but It has several issues
* line selection doesn't work properly with if conditionals (probably more) -
see the annotated screenshot
* the user has to use twice as much keys as in 7.3 to get the same result - the
new selection type has no real advantage IMHO 

So I propose to revert the line selection behaviour  in "Select Next Element"

[1] https://netbeans.org/bugzilla/show_bug.cgi?id=215552

Comment 1 markiewb 2013-06-05 22:43:13 UTC

Created attachment 135408 [details]
Proposed patch, which removes the line selection code

Comment 2 markiewb 2013-06-05 22:46:14 UTC

Created attachment 135409 [details]
Shows the issue with if conditionals, it doesn't widen the selection

Comment 3 markiewb 2013-06-05 22:48:55 UTC

@Dusan: Please review the issue. What do you think? Is the removal of line selection with the arguments described above reasonable for you?

If yes, then I already prepared a patch.

Comment 4 Dusan Balek 2013-06-06 14:03:25 UTC

IMHO - better solution would be to fix the particular bugs in line selection and see how does it work. Personally, I have to admit that I like the line selection added to the action.

http://hg.netbeans.org/jet-main/rev/35b45aa83a80

Comment 5 Quality Engineering 2013-06-10 02:19:56 UTC

Integrated into 'main-golden', will be available in build *201306100004* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/35b45aa83a80
User: Dusan Balek <dbalek@netbeans.org>
Log: Issue #230812: Fixing the 'Select Next Element' action's line selection issues and usability.