This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 229459

Summary:	Split module Hudson into Core and UI
Product:	connecteddeveloper	Reporter:	Jaroslav Havlin <jhavlin>
Component:	Hudson	Assignee:	Jaroslav Havlin <jhavlin>
Status:	RESOLVED FIXED
Severity:	normal	CC:	apireviews, tpavek
Priority:	P3	Keywords:	API_REVIEW_FAST
Version:	7.4
Hardware:	PC
OS:	Windows 7
Issue Type:	TASK	Exception Reporter:
Attachments:	Proposed Patch Proposed Patch

Description Jaroslav Havlin 2013-05-07 12:41:08 UTC

Module Hudson currently contains core functionality for communication with builders as well as the UI. These two parts should be separated to make the module more reusable.

Comment 1 Jaroslav Havlin 2013-05-07 12:43:57 UTC

Created attachment 134183 [details]
Proposed Patch

Patch containing changes in the API and in affected modules.

Comment 2 Jaroslav Havlin 2013-05-07 12:56:29 UTC

Please review changes in module Hudson.
The UI-related part has been moved to new module Hudson UI (hudson.ui).
Note that this is a friend-only API.

The patch is not very polished (some javadoc is missing), but I hope that an early review could be helpful.

P.S. Unfortunately, I won't be able to continue working on the patch until the beginning of the next week. Thank you for understanding.

Comment 3 Jaroslav Tulach 2013-05-07 13:54:20 UTC

Y01 I don't understand why you are moving interfaces like ProjectHudsonJobCreatorFactory around. Can't they stay where there are?

Comment 4 Jaroslav Havlin 2013-05-07 14:06:03 UTC

> Y01 I don't understand why you are moving interfaces like
> ProjectHudsonJobCreatorFactory around. Can't they stay where there are?
Module Hudson cannot have dependency on Project API (it's not available in JDev).

Comment 5 Jaroslav Havlin 2013-05-14 14:08:42 UTC

Created attachment 134425 [details]
Proposed Patch

Updated patch:
 - Class UsageLogging moved to module hudson.ui
 - Specification version of module hudson changed to 2.0
 - Fixed module odcs.hudson
 - Added missing javadoc

Comment 6 Jaroslav Havlin 2013-05-16 06:05:19 UTC

If there are no objections, I'll integrate the patch tomorrow.
Thank you for reviewing.

Comment 7 Jaroslav Havlin 2013-05-17 10:12:00 UTC

Patch integrated as http://hg.netbeans.org/core-main/rev/052a2210a807

Comment 8 Quality Engineering 2013-05-19 02:53:16 UTC

Integrated into 'main-golden', will be available in build *201305182300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/052a2210a807
User: Jaroslav Havlin <jhavlin@netbeans.org>
Log: #229459: Split module Hudson into Core and UI