This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 229281

Summary:	replace private contract via fo.GetAttribute with versioning query
Product:	projects	Reporter:	Tomas Stupka <tstupka>
Component:	Generic Infrastructure	Assignee:	apireviews <apireviews>
Status:	RESOLVED FIXED
Severity:	normal	CC:	apireviews, ralphbenjamin, tpavek
Priority:	P3	Keywords:	API, API_REVIEW_FAST
Version:	7.3
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Attachments:	proposed changes in the queries module

Description Tomas Stupka 2013-05-02 14:14:34 UTC

Product Version = NetBeans IDE Dev (Build 20130502-9fc430ac8116)
Operating System = Mac OS X version 10.8.2 running on x86_64
Java; VM; Vendor = 1.7.0_17
Runtime = Java HotSpot(TM) 64-Bit Server VM 23.7-b01

there is a private contract between versioning systems on one side and refactoring and team modules on the other side. FileObject.getAttribute(...) is used to retrieve versioning relevant information:

1.) "ProvidedExtensions.VCSManaged" - determines if a file is managed by a versionig system (used by refactoring and team modules)
2.) "ProvidedExtensions.RemoteLocation" - returns a string value representing a files remote repository or origin in case it is versioned (used only by team modules)

preferably the 2 private attributes would be replaced by a public query ...

Comment 1 Tomas Stupka 2013-05-02 14:19:26 UTC

Created attachment 134042 [details]
proposed changes in the queries module

Comment 2 Milos Kleint 2013-05-03 04:38:00 UTC

looks ok to me

Comment 3 Tomas Stupka 2013-05-15 10:00:28 UTC

will integrate tomorrow in case nobody objects

Comment 4 Tomas Stupka 2013-05-16 10:29:05 UTC

fixed in core-main #7f7224c36943

Comment 5 Tomas Stupka 2013-05-16 10:29:52 UTC

vcs relevant changes core-main #a94b3e4bc223

Comment 6 Quality Engineering 2013-05-17 09:52:18 UTC

Integrated into 'main-golden', will be available in build *201305170640* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/7f7224c36943
User: Tomas Stupka <tstupka@netbeans.org>
Log: Issue #229281 - replace private contract via fo.GetAttribute with versioning query