This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 227911

Summary:	org.netbeans.modules.editor.indent.IndentImpl.reformatLock: LowPerformance took 32006 ms.
Product:	php	Reporter:	Exceptions Reporter <exceptions_reporter>
Component:	Editor	Assignee:	Ondrej Brejla <obrejla>
Status:	RESOLVED FIXED
Severity:	normal	CC:	error403, gokiyono, sdedic
Priority:	P3	Keywords:	PERFORMANCE
Version:	7.3
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:	199873
Attachments:	nps snapshot

Description Exceptions Reporter 2013-03-25 15:00:56 UTC

This bug was originally marked as duplicate of bug 213605, that is already resolved. This bug is still valid, so this seems to be another bug, but it might be related.

Build: NetBeans IDE 7.3 (Build 201302132200)
VM: Java HotSpot(TM) Client VM, 23.7-b01, Java(TM) SE Runtime Environment, 1.7.0_17-b02
OS: Windows 7
Maximum slowness yet reported was 32006 ms, average is 32006

Comment 1 Exceptions Reporter 2013-03-25 15:01:01 UTC

Created attachment 133042 [details]
nps snapshot

Comment 2 Dusan Balek 2013-03-28 10:53:01 UTC

AWT EDT (inside GsfReformatTask) waits for the parser lock which is held by PHPHintsProvider.computeErrors(). Please consider to make the PHPHintsProvider cancellable.

Comment 3 Ondrej Brejla 2013-03-28 12:08:14 UTC

Svato, is it possible to make csl.api.HintsProvider cancellable?

Comment 4 Ondrej Brejla 2013-03-28 13:06:57 UTC

Too much queries to index when resolving inherited elements (reporter has probably really big type inheritance).

Comment 5 Svata Dedic 2013-05-16 09:14:27 UTC

The HintsProvider already has a cancel() method, but the method is not actually called. I implemented calling in Hints/Selection/ tasks in rev.
http://hg.netbeans.org/jet-main/rev/94e92ea55bfa

Comment 6 Quality Engineering 2013-05-19 02:53:21 UTC

Integrated into 'main-golden', will be available in build *201305182300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/94e92ea55bfa
User: Svata Dedic <sdedic@netbeans.org>
Log: #227911: CSL forwards cancel request to the HintsProvider being just executed

Comment 7 Ondrej Brejla 2013-05-28 13:37:54 UTC

PHP Hints are cancellable. Probably it could work now, when CSL passes cancel :) Can't do more (maybe rewriting index querying should help...it's planned for some of next releases).