This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Chrome plugin installation check will not work in non-English locale | ||
---|---|---|---|
Product: | ide | Reporter: | Petr Jiricka <pjiricka> |
Component: | Extbrowser | Assignee: | David Konecny <dkonecny> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jstola, tmysik |
Priority: | P2 | Keywords: | I18N |
Version: | 7.3 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
Petr Jiricka
2012-10-31 16:18:52 UTC
I suggest we do not localize the plugin name - it will always be "NetBeans Connector". Otherwise I'm not sure how to change the implementation - recognize presence of NB plugin according to what? icon being "img/netbeans16.png"? Could do. (In reply to comment #1) > icon being "img/netbeans16.png"? Could do. Or add some "special" image/file with hard-to-guess (hashed?) filename that would server just for this recognition? There is no need for such hacks. The extension has a unique ID that is derived from its public key (that is included in the .crx file), see [1]. The ID of our extension is "hafdlehgocfcodbgjnpecfajgkeejnaa". Hence, instead of checking the name, we should check the ID. FYI: The ID of the registered extension can be obtained through e.getKey() where e is the variable from line 161 in ChromeManagerAccessor.java. [1] http://developer.chrome.com/extensions/packaging.html Thanks for pointing this out, but one thing to remember is that the ID of the extension when uploaded to Chrome Web Store is different - the URL of the plugin is https://chrome.google.com/webstore/detail/netbeans-connector/ehdgmbjjaocpjdnapfadcldificeaaki I will use directly the public key instead of ID. 5cd1e4bc2a29 Integrated into 'main-golden', will be available in build *201211070001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/5cd1e4bc2a29 User: David Konecny <dkonecny@netbeans.org> Log: #221196 - Chrome plugin installation check will not work in non-English locale |