This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | java.net.URISyntaxException: Illegal character in path at index 22: http://localhost:8383/ d d/index.html | ||
---|---|---|---|
Product: | ide | Reporter: | Vladimir Riha <vriha> |
Component: | Extbrowser | Assignee: | David Konecny <dkonecny> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | anebuzelsky, kganfield, mmirilovic, pjiricka, tmysik, vriha |
Priority: | P1 | ||
Version: | 7.3 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | 191314 |
Attachments: | stacktrace |
Description
Vladimir Riha
2012-08-06 11:40:17 UTC
Created attachment 122781 [details]
stacktrace
*** Bug 217528 has been marked as a duplicate of this bug. *** David, I thought you were fixing something like this recently, right? reproducible in Product Version: NetBeans IDE Dev (Build 201209200001) Updates: Updates available Java: 1.7.0; Java HotSpot(TM) 64-Bit Server VM 21.0-b17 System: Linux version 3.5.0-4-generic running on amd64; UTF-8; en_US (nb) I did, but not everywhere. I did not test it for non-existent path. Tomas, could you review my fix please? There is no utility method AFAICT to convert string URL into URL which does not fail when toURI() is called on it. So I had to create my own utility: b9ae852e2715 To reproduce open Proj Props and set Web Root to a value with spaces in it. I tried to put spaces everywhere, eg. http://localhost:8383/HTML%205%20Application/a%20a%20a%20a/i%20n%20d%20e%20x.html and it seems to work but testing this well would be good. Workaround is obvious: do not use spaces in your web root. Thanks. I think that your solution is good. Another (perhaps a bit ugly) way to do it could be: new URI("http", "//localhost/my folder?my key=my value", null).toURL() Of course, the best way would be: org.apache.commons.httpclient.util.URIUtil.encodeQuery("http://localhost/my folder?my key=my value"); Tomas, could you integrate this fix into the branch as well please after it was tested by QA? Thanks. Otherwise I will do it tomorrow morning my time. I'll test in ~2hours (once my local build finished) (In reply to comment #8) > Tomas, could you integrate this fix into the branch as well please after it was > tested by QA? Thanks. Otherwise I will do it tomorrow morning my time. Will do it, no problem. Adding keyword. unable to reproduce the way I did (simply add spaces to web root), please backport Product Version: NetBeans IDE Dev (Build 20120921-5ed37588c5fc) Java: 1.7.0_07; Java HotSpot(TM) Client VM 23.3-b01 System: Linux version 3.2.0-30-generic-pae running on i386; UTF-8; en_US (nb) Backported however I had to manually fix conflict in dependencies - Davide, please verify the patch. Thanks. http://hg.netbeans.org/releases/rev/0550ac0ad81d I am not sure the spec version increase is correct, they differ intentionally in beta vs. trunk, see Tonda's commits: http://hg.netbeans.org/web-main/rev/ac5f3444bb61 http://hg.netbeans.org/releases/rev/df13c208b8c4 Shoudn't the version on the beta branch be 1.3.2? (In reply to comment #14) > Shoudn't the version on the beta branch be 1.3.2? You are probably right... Tondo, can you confirm? I would fix it in the beta branch. Thanks. > I am not sure the spec version increase is correct,
> they differ intentionally in beta vs. trunk
What the scripts do for a branch and for the trunk is the following:
trunk before branching - spec version was A.B
on the new branch - spec will be A.B.1
trunk after the branching - new spec will be A.B+1
This ensures that the spec versions of all modules in comparison meet the following rule:
before branching < on the branch < after branching on trunk
If you are trying to increase the spec version of a module on the branch to be higher than the spec version on trunk now then this is wrong.
If I understand it correctly, PetrJ was right. I will fix it on the branch. (In reply to comment #17) > If I understand it correctly, PetrJ was right. I will fix it on the branch. Done. I would appreciate if anyone could review it. Thanks. http://hg.netbeans.org/releases/rev/d034352b331e Thanks, that's exactly what I was thinking it should be. Integrated into 'main-golden', will be available in build *201209220001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/b9ae852e2715 User: David Konecny <dkonecny@netbeans.org> Log: #216436 - java.net.URISyntaxException: Illegal character in path at index 22: http://localhost:8383/ d d/index.html verified in Beta, but it introduced issue 218889 Product Version: NetBeans IDE 7.3 Beta (Build 201209232010) Java: 1.7.0_07; Java HotSpot(TM) Client VM 23.3-b01 System: Linux version 3.2.0-30-generic-pae running on i386; UTF-8; en_US (nb) |