This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | DataObject.getNodeDelegate has double check locking idiom | ||
|---|---|---|---|
| Product: | platform | Reporter: | Chris Webster <cwebster> |
| Component: | Data Systems | Assignee: | _ ttran <ttran> |
| Status: | CLOSED WORKSFORME | ||
| Severity: | blocker | Keywords: | THREAD |
| Priority: | P3 | ||
| Version: | 3.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
added THREAD keyword I don't see this construct in CVS trunk anymore. The faulty code has disappeared as part of other commits Resolved for 3.4.x or earlier, no new info since then -> verified Resolved for 3.4.x or earlier, no new info since then -> closing. |
I was looking at the code for DataObject.getNodeDelegate() and I noticed the following construct: if (nodeDelegate == null) { getPrimaryFileListener() ... which eventually ends up calling synchronized (fileListener) { if (nodeDelegate == null) { nodeDelegate = ...; } } } which is the double check locking idiom which could potentially cause threading problems. The refactoring is to perform the initial test in a synchronized block.