[JG01] Would want to see at least one impl, say in core.multiview, and at least one caller, say the popup switcher.
[JG02] The default impl is documented to return null but it is unclear what this means and whether subclasses can do the same. Would prefer to return an empty array unless there is a specialized meaning for null.
[JG03] The lifecycle and threading behavior of SubComponent is unclear. Hold long may the caller hold on to these objects? What happens if a new tab appears? Or a tab that has already been returned is closed? Or a different tab is selected so that the 'active' fields in two tabs are now wrong? Must all calls to getSubComponents, and calls to SubComponent methods, be on EQ?
[JG04] Constructors for abstract classes should be marked protected as a stylistic matter.
Comment 4Stanislav Aubrecht
2012-03-02 10:36:37 UTC
Comment 6Stanislav Aubrecht
2012-03-02 10:47:50 UTC
JG01: i've added core.multiview implementation. the new popup switcher is still work in progress so i can't provide a working patch. but the idea is to allow Ctrl+Tab switching to individual sub-tabs in multiview windows (and also possibly to e.g. Output window's sub-tabs), see UI specification here:
JG02: i've changed that, see the new patch
JG03: i've clarified the javadoc
JG04: fixed, see the new patch