This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | VersioningSystem should use CollocationQueryImplementation2 | ||
---|---|---|---|
Product: | versioncontrol | Reporter: | Alexander Simon <alexvsimon> |
Component: | Code | Assignee: | Tomas Stupka <tstupka> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | apireviews, issues, jglick |
Priority: | P2 | Keywords: | API_REVIEW_FAST |
Version: | 7.2 | ||
Hardware: | PC | ||
OS: | Solaris | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 195124 | ||
Attachments: |
proposed changes in versioning and versioning.core
proposed changes in versioning and versioning.core proposed changes in versioning and versioning.core |
Description
Alexander Simon
2012-01-16 11:24:16 UTC
*** This bug has been marked as a duplicate of bug 206932 *** Tomas, could you estimate when can we expect fix for this blocker of #195124? thanks my mistake, this is about the CollocationQuery, not SharabilityQuery Created attachment 114939 [details]
proposed changes in versioning and versioning.core
changed return type in o.n.m.versioning.core.spi.VersioningSystem.getCollocationQuery() to CollocationQueryImplementation2 please review Why does VcsCollocationQueryImplementation still implement CollocationQueryImplementation and register itself as a service provider of that? If possible, all usages of CollocationQueryImplementation should be replaced with CollocationQueryImplementation2 (other than in CollocationQuery itself, for compatibility). Created attachment 115054 [details]
proposed changes in versioning and versioning.core
fixed VcsCollocationQueryImplementation from the previous patch where it was obviously wrong
[JG01] Patch to Utils.java probably gratuitous. [JG02] Careful with path.lastIndexOf("/") (or path.lastIndexOf('/') if you accept the hint to fix it); file:/tmp/somedir/ might not exist but file:/tmp/somedir is meaningless (the parent is file:/tmp/). The easiest way to get a URI parent is new URI(child + '/').resolve("..") which seems to fail only for file:/ which is I guess a special case. > [JG01] Patch to Utils.java probably gratuitous. indeed > [JG02] Careful with path.lastIndexOf("/") (or path.lastIndexOf('/') if you accept the hint to fix it); file:/tmp/somedir/ might not exist but file:/tmp/somedir is meaningless (the parent is file:/tmp/). The easiest way to get a URI parent is > new URI(child + '/').resolve("..") suggestion applied will integrate tomorrow in case no other objections are raised Created attachment 115159 [details]
proposed changes in versioning and versioning.core
Integrated into 'main-golden', will be available in build *201201250600* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/dc1548a9bf0b User: Tomas Stupka <tstupka@netbeans.org> Log: Issue #207340 - VersioningSystem should use CollocationQueryImplementation2 |