This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | "Could not lock document" from LexerBasedHighlightLayer.setColorings | ||
---|---|---|---|
Product: | java | Reporter: | Jesse Glick <jglick> |
Component: | Editor | Assignee: | Jan Lahoda <jlahoda> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | emononen, mmetelka, mmirilovic, vv159170 |
Priority: | P2 | ||
Version: | 7.1 | ||
Hardware: | PC | ||
OS: | Linux | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 206858 |
Description
Jesse Glick
2011-11-11 16:48:48 UTC
I do not remember exactly why runAtomic was used (maybe to ensure that noone is reading the highlights?). I do not see a reason for it in the current code, so I will probably try to change the lock to a read lock. But, this worked fine for years (see #87642) - possibly related to redo after save? Mila, adding you on CC just in case you would be interested. Honzo, regarding runAtomic()/render() I wanted to ask the same question :) I've came to the same fix since Vladimir was complaining regarding beeping during Ctrl-TAB focus change between readonly files and I've found that this runAtomic() was the culprit. I've run java.editor unit tests and they seem to pass fine. http://hg.netbeans.org/jet-main/rev/48ecb1618e52 Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/48ecb1618e52 User: Miloslav Metelka <mmetelka@netbeans.org> Log: #205002 - "Could not lock document" from LexerBasedHighlightLayer.setColorings according to Mila, the provided patch solves also problems reported in #206858 which is a P1 regression. Please provide a patch for 7.1. *** Bug 206858 has been marked as a duplicate of this bug. *** We will address this issue in Patch 1 for 7.1 (aka 7.1.1) *** Bug 205415 has been marked as a duplicate of this bug. *** verified in trunk release71_fixes: http://hg.netbeans.org/releases/rev/570517912912 Integrated into 'releases', will be available in build *201202082200* or newer. Wait for official and publicly available build. Changeset: http://hg.netbeans.org/releases/rev/570517912912 User: Miloslav Metelka <mmetelka@netbeans.org> Log: #205002 - "Could not lock document" from LexerBasedHighlightLayer.setColorings |