This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Review of ConstrainedBinaryIndexer | ||
|---|---|---|---|
| Product: | editor | Reporter: | Tomas Zezula <tzezula> |
| Component: | Parsing & Indexing | Assignee: | Tomas Zezula <tzezula> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jglick, marfous |
| Priority: | P3 | Keywords: | API, API_REVIEW_FAST, PERFORMANCE |
| Version: | 7.1 | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | TASK | Exception Reporter: | |
| Bug Depends on: | |||
| Bug Blocks: | 200050 | ||
| Attachments: | Patch file | ||
|
Description
Tomas Zezula
2011-11-08 09:30:38 UTC
Probably missing patch? Created attachment 112994 [details]
Patch file
[JG01] Typo - "constrains" (as a noun) should be "constraints" (several places). [JG02] "paths inside the binary files" seems vague. [JG03] XSD_MIME = "text/xml" seems odd; IIRC there is a special MIME subtype inside NB for *.xsd. JG01 + JG02 : Fixed JG03: Yes we have mime resolver for xsd but the XSD mime resolver returns text/xml as mime type. JG03 - then maybe that should be fixed now. AFAIK should be harmless for existing code to switch the resolver to producing a subtype. Overall concept seems fine.
Y01 Javadoc for mimeType() is wrong "Use <code>{}</code> if the resource check should be skipped" - it should not talk about resources.
Y02 Slightly unrelated, but don't forget to make parsing.api stable - change nbbuild/build.properties and parsing.api/arch.xml
Y01: Fixed Y02: Next week Fixed jet-main d054f910d8f6 Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/d054f910d8f6 User: Tomas Zezula <tzezula@netbeans.org> Log: #204817:Review of ConstrainedBinaryIndexer |