This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | can't search in diff window | ||
---|---|---|---|
Product: | editor | Reporter: | tbrunhoff <tbrunhoff> |
Component: | Search | Assignee: | Milutin Kristofic <mkristofic> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | MackSix |
Priority: | P4 | ||
Version: | 7.1 | ||
Hardware: | PC | ||
OS: | Linux | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 213397 | ||
Attachments: |
search working
screenshot of ide screenshot of condition 3 |
Description
tbrunhoff
2011-10-06 23:49:27 UTC
> I can do some navigation, but only the right hand graphical view
... and whatever navigation I do only affects the edit window, not the diff window.
Some edit functionality is present, like copy and paste.
I must say i don't fully follow your request, as far as i know search works (Ctrl+F) in the diff view and when you're searching in the right pane the left view lines up with the position in the right view. Please explain again more thoroughly (step by step) what bothers you. Created attachment 111629 [details]
search working
Created attachment 111669 [details]
screenshot of ide
When I have a diff-window and hit ctrl-f, I get a Find dialog box, like in the attached screenshot... I don't get the search bar like I get in the edit window. The Find dialog box highlights all instances of the "Find What" text, and it shows the description of the instances found in the status line at the bottom of the ide, but it does *not* scroll the diff window to the current selection, and it does not highlight the selected text in blue.
Another condition: - open a diff window open - type ctrl-f (this find dialog opens) - click 'close' This causes the ide to switch to the last used edit window. It should not switch. Created attachment 111671 [details]
screenshot of condition 3
Condition #3:
- open file A in the editor (smpte377.h in the screenshot)
- open file B in the editor (container.cc in the screenshot)
- make changes to file B and open a (subversion) diff window on file B (container.cc [Diff] in the screenshot)
- undock the diff window and move it aside.
- in the edit window select file A (very important)
- click in the right side of the diff window, and type ctrl-f (the Find dialog pops up)
- type text into the "Find What" box that occurs in file B and the diff window, but *does not* occur in file A. Click 'Find'
As illustrated, "lowerBound" is highlighted in yellow in the diff window, but the status bar in the lower right shows "lowerBound not found". Clearly the find box is searching the editor window, *not* the diff window.
These problems are not difficult to find. If you don't have QA sequences like the ones I have described, someone should add them. mito, i think it works fine (except for the problem described in comment #5) but according to the reporter there are still some issues with Find... in the diff view. Can you take a look? I know search in diff is not ideal. However, it has not been possible to use searchbar yet and this is a solution to have at least some search option. This are minor bugs in deprecated search functionality -> P4 P4 is fine. I did notice yesterday that I was able to search in the diff window in ways that did not work earlier. So there is some other condition where searching does not work at all (which you probably have not experienced). I'll have to figure out how to get there and write it down. Ondra helped me to implement searchbar for diff. http://hg.netbeans.org/jet-main/rev/b632d8c030bf Integrated into 'main-golden', will be available in build *201205250002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/b632d8c030bf User: Milutin Kristofic <mkristofic@netbeans.org> Log: #203271 - can't search in diff window |