This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Patch for: Command to reset the zoom level - plugin available | ||
---|---|---|---|
Product: | editor | Reporter: | 280Z28 |
Component: | Painting & Printing | Assignee: | Miloslav Metelka <mmetelka> |
Status: | NEW --- | ||
Severity: | normal | CC: | 280Z28, joecsc, markiewb, mkristofic |
Priority: | P4 | Keywords: | PATCH_AVAILABLE |
Version: | 7.1 | ||
Hardware: | PC | ||
OS: | Other | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Attachments: | Proposed patch draft |
Description
280Z28
2011-10-06 14:46:26 UTC
Created attachment 132924 [details]
Proposed patch draft
I like to propose the following patch to solve the issue.
The patch introduces the new editor action name "zoom-text-reset" and integrates it in the existing ZoomTextAction. It includes an API-Change because the name is defined in editor.lib2, which is used by editor.actions.
The code looks OK, but i wasn't able to run it because of some module-loading/dependency-issue that i couldn't resolve yet.
@NB-Dev: Please review and give it a try yourself.
Thank you for the patch. mkristofic is currently working on some deeper integration of editor's zoom action with system zoom action so I'll let him to integrate to not clash with his changes. Just a nitpick: in the patch we could retain the "delta" variable for all three cases just making delta = -currentZoom for the reset case. Since we recently switched to JDK7 we could even use switch-case over string literals ;-) (In reply to comment #2) > Thank you for the patch. mkristofic is currently working on some deeper > integration of editor's zoom action with system zoom action so I'll let him to > integrate to not clash with his changes. Thank you for your feedback. When mkristofic is done, i could regenerate the patch if required. > Just a nitpick: in the patch we could retain the "delta" variable for all three > cases just making delta = -currentZoom for the reset case. Since we recently > switched to JDK7 we could even use switch-case over string literals ;-) I will take this in account for the next patch. Any news here? It is pending for at least 1 year. BTW: In the meantime I created http://plugins.netbeans.org/plugin/53555/?show=true which supports reset zoom too (In reply to Miloslav Metelka from comment #2) > mkristofic is currently working on some deeper > integration of editor's zoom action with system zoom action so I'll let him > to integrate to not clash with his changes. Did those changes already land? Even if not, is there something that speaks against applying Markie's patch? Sebastian Lowering prio to P4. A plugin exists |