This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 202535

Summary: areThereNewFiles() should not be called in AWT thread
Product: installer Reporter: Jiri Skrivanek <jskrivanek>
Component: CodeAssignee: Jiri Rechtacek <jrechtacek>
Status: VERIFIED FIXED    
Severity: normal CC: anebuzelsky, cyhelsky, mmirilovic
Priority: P3 Keywords: PERFORMANCE
Version: 7.1   
Hardware: PC   
OS: Windows XP   
Issue Type: DEFECT Exception Reporter:
Attachments: Thread dump.

Description Jiri Skrivanek 2011-09-23 06:54:45 UTC
Created attachment 111071 [details]
Thread dump.

When you run uninstaller it seems it hangs because the method bellow runs in dispatch thread. It takes several minutes on my WindowsXP. It should be re-plan to separate thread to not block UI.

NbPreInstallSummaryPanel$NbPreInstallSummaryPanelSwingUi.areThereNewFiles(NbPreInstallSummaryPanel.java:529)
Comment 1 Antonin Nebuzelsky 2011-09-26 13:04:28 UTC
Is this really a P2 performance problem. I don't think this is a regression. Downgrading to P3.

Though this should be fixed.
Comment 2 Yulia Novozhilova 2011-09-26 13:15:14 UTC
I'm working on the fix.
Comment 3 Marian Mirilovic 2011-12-07 10:00:19 UTC
It is P2 ... all together it means uninstall takes 15 minutes and this is not acceptable.
Comment 4 Petr Cyhelsky 2011-12-08 12:32:54 UTC
Now that Issue #205702 is fixed this is not so urgent -> P3
Comment 5 Jiri Rechtacek 2011-12-08 12:34:58 UTC
I'm fixing this anyway....
Comment 6 Jiri Rechtacek 2011-12-08 14:20:10 UTC
areThereNewFiles() is not called from AWT, I added a assertion this state. I also I improve a little user's feedback while computing new files.

core-main/rev/d8a72a485dcf
Comment 7 Quality Engineering 2011-12-09 12:09:57 UTC
Integrated into 'main-golden', will be available in build *201112090600* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/d8a72a485dcf
User: Jiri Rechtacek <jrechtacek@netbeans.org>
Log: #202535: add a check to don't run computation in EQ