This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 202417

Summary: CVS Commit & Update Issues for ext Access Method
Product: versioncontrol Reporter: Soham_Majumder
Component: CVSAssignee: Ondrej Vrabec <ovrabec>
Status: RESOLVED FIXED    
Severity: normal CC: jkovalsky, vsitnikov
Priority: P3 Keywords: NETFIX
Version: 7.0   
Hardware: PC   
OS: Windows XP   
Issue Type: DEFECT Exception Reporter:
Attachments: Contains Screenshot for Commit & Update error messages
As requested by ovrabec
patch
Correct patch

Description Soham_Majumder 2011-09-21 12:40:37 UTC
Created attachment 110964 [details]
Contains Screenshot for Commit & Update error messages

Hi,

We have noticed that once a project has been uploaded/checked-in by NetBeans to CVS then the next time when we try to Update/Commit, there is an unusual error and a possible bug in the code, which is as follows:

Example Project:
Name: CVSTesting
CVS Import to Repository Name/Module: CVSTesting
CVS Path for the Module: /cvsroot/pspf/CVSTesting

While Updating/Commiting NetBeans selects /cvsroot/pspf//VSTesting, which is particullarly missing the first character 'C' for the Module Name for the CVS Project.

This is happening only when we try to Update/Commit projects.

The error message is as follows in the Output window:

IDE:-------------------------------------------------
IDE: [9/21/11 5:52 PM] Updating "CVSTesting" started
cvs update: Updating .
cvs update: cannot open directory /cvsroot/pspf//VSTesting: No such file or directory
cvs update: skipping directory 
IDE: [9/21/11 5:52 PM] Updating "CVSTesting" finished

IDE:-------------------------------------------------
IDE: [9/21/11 5:58 PM] Refreshing CVS Status started
A NewClass.java
IDE: [9/21/11 5:58 PM] Refreshing CVS Status finished


Need ur urgent help.!!!!!
Comment 1 Ondrej Vrabec 2011-09-22 12:59:36 UTC
paste output of ...src\cvstesting\CVS\Repository
Comment 2 Ondrej Vrabec 2011-09-22 13:00:29 UTC
(In reply to comment #1)
> paste output of ...src\cvstesting\CVS\Repository
i meant content of course
Comment 3 Soham_Majumder 2011-09-23 08:21:20 UTC
Created attachment 111073 [details]
As requested by ovrabec

Attached the file and the Data inside the file is :

VSTesting/nbproject
Comment 4 Ondrej Vrabec 2011-09-23 12:06:54 UTC
(In reply to comment #3)
> VSTesting/nbproject
Co it's already wrong in metadata, how did you checkout the project? Where is the project stored locally (the full path to the project folder)? Can you make a fresh checkout into another folder and try again?
Comment 5 vsitnikov 2011-09-28 19:04:09 UTC
We noticed this bug too... one of our four developers got that bug in NB 6.9 after upgrade from 6.8. The rest of us did't got this bug after upgrade.

The first character is missed if checkout was performed via NetBeans, if checkout was performed via CVS command line tool it doesn't happen.
Comment 6 vsitnikov 2011-09-28 19:08:40 UTC
Oh, previously I said "one of four of our developers"... This should not considered to be a clue because they could not encounter the problem because the project was checked out using nb 6.8
Comment 7 vsitnikov 2011-10-02 15:44:38 UTC
Hi, can I fix this issue as a NetFIX participant?
Comment 8 Ondrej Vrabec 2011-10-02 20:27:01 UTC
(In reply to comment #7)
> Hi, can I fix this issue as a NetFIX participant?
I would definitely be glad to review your patch. I have no intention of fixing it myself.
Comment 9 vsitnikov 2011-10-10 17:50:29 UTC
Created attachment 111806 [details]
patch
Comment 10 vsitnikov 2011-10-10 18:01:51 UTC
Created attachment 111807 [details]
Correct patch
Comment 11 vsitnikov 2011-10-10 18:06:18 UTC
The problem is that CVS Client Library does not correctly handle repository
part of cvsroot which contains file separator repetitions and trailing file
separator. This results in for example such seemed to be correct cvsroot
"/usr/local/CVSROOT/" causes mistake in StandardAdminHandler.updateAdminData;

Instead of fixing udpateAdminData patch fixes CVSRoot.setRepository and GlobalOptions.setCVSRoot methods;

Please review my patch and notify me the conclusion;
Comment 12 Ondrej Vrabec 2011-10-12 11:01:46 UTC
Patch makes sense in general. But before committing your changes i would like to test it and see if it fixes this problem. I tried on windows but was unable to get into the same problem.
> The first character is missed if checkout was performed via NetBeans, if checkout was performed via CVS command line tool it doesn't happen.
Can you describe step by step the process of the checkout (exactly what you enter into fields) that leads to the wrong value of repository path?
Comment 13 vsitnikov 2011-10-12 16:03:28 UTC
Ok. Just ordinar checkout via nb 7, set the following CVS root
:pserver:anonymous@javacsv.cvs.sourceforge.net:/cvsroot/javacsv/
Accomplish checkout and you will see the problem when check admin files.

If you set the same root but without trailing slash the problem won't appear
:pserver:anonymous@javacsv.cvs.sourceforge.net:/cvsroot/javacsv

I sure this will help.
Regards
Comment 14 Ondrej Vrabec 2011-10-13 15:19:33 UTC
Thanks, i'll commit your patch.
Comment 15 Ondrej Vrabec 2011-10-13 15:30:51 UTC
fixed: http://hg.netbeans.org/core-main/rev/2d93757c567f
Comment 16 Jiri Kovalsky 2011-10-14 09:47:58 UTC
Thanks Ondro for review of Vladimir's patch and its integration. And a special thanks to you Vladimir for the patch!
Comment 17 Quality Engineering 2011-10-14 15:10:30 UTC
Integrated into 'main-golden'
Changeset: http://hg.netbeans.org/main-golden/rev/2d93757c567f
User: Vladimir Sitnikov <vsitnikov@netbeans.org>
Log: Issue #202417 - CVS Commit & Update Issues for ext Access Method