This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Possibility to disable NbAuthenticator | ||
---|---|---|---|
Product: | platform | Reporter: | Ondrej Vrabec <ovrabec> |
Component: | -- Other -- | Assignee: | Jiri Rechtacek <jrechtacek> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | anebuzelsky, jglick |
Priority: | P3 | Keywords: | API_REVIEW_FAST |
Version: | 7.0 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | TASK | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 200692 | ||
Attachments: |
a proposed API w/ API usage
a proposed API w/ API usage a proposed API w/ API usage, version 3 |
Description
Ondrej Vrabec
2011-09-06 07:22:15 UTC
Created attachment 110739 [details]
a proposed API w/ API usage
Please review proposed patch - more detail found in http://wiki.netbeans.org/Authenticator. I'm going to integrate it on Tue 20/9 before branching Beta. Thanks Needs to be integrated on Monday at the latest. Created attachment 110762 [details]
a proposed API w/ API usage
Git passes username in the URL, so the two conditions in NbAuthenticator (just before opening the authentication dialog) need to be swapped
Y01 Based on bug 20216: Don't print warnings when there is a provider Y02 Typo? "Tn the case" Y03 Use CountDownLatch instead of Thread.sleep(100) and final boolean[] barrier = new boolean[2]; Btw. ProxyCredentialsProvider is a good name. Created attachment 110792 [details] a proposed API w/ API usage, version 3 > Y01 Based on bug 20216: Don't print warnings when there is a provider fixed > Y02 Typo? "Tn the case" fixed > Y03 Use CountDownLatch instead of Thread.sleep(100) and final boolean[] barrier = new boolean[2]; done Thanks for review. I'm going to integrate patch,ver3 in a few hours. core-main/rev/2c5e534f8cd6 <a href="http://download.oracle.com/javase/6/docs/api/java/net/Authenticator.html">Authenticator</a> is a silly way of writing {@link java.net.Authenticator}. Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/2c5e534f8cd6 User: Jiri Rechtacek <jrechtacek@netbeans.org> Log: #201662: Possibility to disable NbAuthenticator (In reply to comment #9) > <a > href="http://download.oracle.com/javase/6/docs/api/java/net/Authenticator.html">Authenticator</a> > is a silly way of writing {@link java.net.Authenticator}. Sure, I don't know how come. Fixed in http://hg.netbeans.org/core-main/rev/706df373cbea Thanks (In reply to comment #11) > (In reply to comment #9) >> <a href="http://download.oracle.com/javase/6/docs/api/java/net/Authenticator.html">Authenticator</a> >> is a silly way of writing {@link java.net.Authenticator}. > > Sure, I don't know how come. Fixed in > http://hg.netbeans.org/core-main/rev/706df373cbea No, this was wrong. In apichanges.xml you cannot use @link (though you can and should replace the base URL with @JDK@). I was referring to the two places in *.java code where you used <a> when @link would have sufficed. Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/cf4e7e01c081 User: Jesse Glick <jglick@netbeans.org> Log: Fixing Javadoc problems ignored in bug #201662 comment #12. |